Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
	       "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	       "Pedro Alves (palves@redhat.com)" <palves@redhat.com>
Subject: Re: [patch] Fix cleanup in finish_command
Date: Fri, 21 Jun 2013 08:23:00 -0000	[thread overview]
Message-ID: <20130621081409.GA30052@host2.jankratochvil.net> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B230A96FF66@IRSMSX104.ger.corp.intel.com>

On Fri, 21 Jun 2013 10:03:21 +0200, Metzger, Markus T wrote:
> > FAIL: gdb.btrace/exception.exp: exception - flat (timeout)
[...]
> it takes a very long time, but the test eventually passes.

OK, I see now, sorry I did not check it more.


> Am I allowed to throw_error() in target functions?
> Or should I just warn and return normally?
> Or just return and not even warn?

There isn't a technical reason why target functions could not throw.
One should just debug why the breakpoint is freed twice, I haven't done so
yet.


Jan


  reply	other threads:[~2013-06-21  8:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-19 21:42 Jan Kratochvil
2013-06-20 14:42 ` Jan Kratochvil
2013-06-20 15:26   ` Joel Brobecker
2013-06-20 15:37     ` Metzger, Markus T
2013-06-20 16:45       ` Jan Kratochvil
2013-06-21  8:14         ` Metzger, Markus T
2013-06-21  8:23           ` Jan Kratochvil [this message]
2013-06-21  8:25             ` Metzger, Markus T
2013-07-02 14:50               ` Metzger, Markus T
2013-06-21 12:56           ` Jan Kratochvil
2013-06-20 16:06     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130621081409.GA30052@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@intel.com \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox