From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5776 invoked by alias); 21 Jun 2013 08:14:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5728 invoked by uid 89); 21 Jun 2013 08:14:18 -0000 X-Spam-SWARE-Status: No, score=-7.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 21 Jun 2013 08:14:17 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5L8EEUj016085 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 21 Jun 2013 04:14:14 -0400 Received: from host2.jankratochvil.net (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5L8E9DT003446 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 21 Jun 2013 04:14:12 -0400 Date: Fri, 21 Jun 2013 08:23:00 -0000 From: Jan Kratochvil To: "Metzger, Markus T" Cc: Joel Brobecker , "gdb-patches@sourceware.org" , "Pedro Alves (palves@redhat.com)" Subject: Re: [patch] Fix cleanup in finish_command Message-ID: <20130621081409.GA30052@host2.jankratochvil.net> References: <20130619211444.GA29379@host2.jankratochvil.net> <20130620143118.GA11929@host2.jankratochvil.net> <20130620151806.GD4724@adacore.com> <20130620161945.GA16142@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-06/txt/msg00577.txt.bz2 On Fri, 21 Jun 2013 10:03:21 +0200, Metzger, Markus T wrote: > > FAIL: gdb.btrace/exception.exp: exception - flat (timeout) [...] > it takes a very long time, but the test eventually passes. OK, I see now, sorry I did not check it more. > Am I allowed to throw_error() in target functions? > Or should I just warn and return normally? > Or just return and not even warn? There isn't a technical reason why target functions could not throw. One should just debug why the breakpoint is freed twice, I haven't done so yet. Jan