From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10046 invoked by alias); 2 Jul 2013 14:50:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10010 invoked by uid 89); 2 Jul 2013 14:50:49 -0000 X-Spam-SWARE-Status: No, score=-7.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 02 Jul 2013 14:50:49 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 02 Jul 2013 07:52:09 -0700 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga002.fm.intel.com with ESMTP; 02 Jul 2013 07:50:46 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.127]) by IRSMSX101.ger.corp.intel.com ([169.254.1.204]) with mapi id 14.03.0123.003; Tue, 2 Jul 2013 15:50:45 +0100 From: "Metzger, Markus T" To: Jan Kratochvil CC: Joel Brobecker , "gdb-patches@sourceware.org" , "Pedro Alves (palves@redhat.com)" Subject: RE: [patch] Fix cleanup in finish_command Date: Tue, 02 Jul 2013 14:50:00 -0000 Message-ID: References: <20130619211444.GA29379@host2.jankratochvil.net> <20130620143118.GA11929@host2.jankratochvil.net> <20130620151806.GD4724@adacore.com> <20130620161945.GA16142@host2.jankratochvil.net> <20130621081409.GA30052@host2.jankratochvil.net> In-Reply-To: Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-07/txt/msg00077.txt.bz2 > -----Original Message----- > From: Metzger, Markus T > Sent: Friday, June 21, 2013 10:23 AM > > > Am I allowed to throw_error() in target functions? > > > Or should I just warn and return normally? > > > Or just return and not even warn? > > > > There isn't a technical reason why target functions could not throw. > > One should just debug why the breakpoint is freed twice, I haven't done= so > > yet. >=20 > I can do this, but I won't be able to start right away. Looks like throwing an error in the to_fetch_registers function is both unexpected and unnecessary. There is already a register_status enum value to indicate that a register is not available. When I simply return, I get exactly what I want, i.e. "info reg" prints all registers except for rip as *value not available*. I'll replace the throws with a simple return. Also in to_store_registers and to_xfer_partial. Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052