Re: [PATCH] gdb: add load-libthread-db-quietly option

[Simon Marchi <simark@simark.ca>]

On 3/1/25 9:10 AM, Eli Zaretskii wrote:
>> Date: Sat, 01 Mar 2025 12:00:54 +0000
>> From: Gregory Heytings <gregory@heytings.org>
>> cc: Eli Zaretskii <eliz@gnu.org>
>>
>> Thanks for the review!  Updated patch attached.
>>
>>>> In line with the Unix tradition in which no messages are displayed when 
>>>> no error happens, I suggest the attached patch, with which users could 
>>>> "set load-libthread-db-quietly off" in their .gdbinit file.
>>>
>>> You mean, "on", right?  Because "off" is the default.
>>>
>>
>> Correct.
>>
>>>
>>> There should be a NEWS entry about this new knob.
>>>
>>
>> Now done.
>>
>>>
>>> This description seems to be backwards, no?  The option, when ON, causes 
>>> the messages NOT to be displayed, right?  So I suggest
>>>
>>>  Turns on or off quiet loading of @code{libthread_db}.  When @code{on},
>>>  @value{GDBN} loads @code{libthread_db} quietly, without any messages.
>>>  The default is @code{off}.
>>>
>>
>> Also correct.
> 
> Thanks, the documentation parts of this are approved.  Now let's see
> if the Powers that Be agree to the code changes...
> 
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>

People ask us to make it possible to turn this or that message on and
off all the time.  The proposed command, "set
load-libthread-db-quietly", is very specific to that use case.  Could we
add perhaps a prefix command (or find an existing appropriate one) that
would allow us to easily add more such knobs?  I'm thinking of something
like (maybe not a good name, but just for the example):

  (gdb) set message load-libthread-db on/off

Simon