From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id jMiAEgXExWc80wMAWB0awg (envelope-from ) for ; Mon, 03 Mar 2025 10:00:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1741014021; bh=1W1+iw17XjF8KpPnOaSLP44GmjQDyBkDRmBQa7kFUUM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VZ1CnumoRhzX0CA+CJtNyj32g6qyiRwFa04x3lEXZTKEm2nBTwsC0Te3Z6zu7QeNG 25cJp7iOTIiCp7LE4Yi3VcIEg1N81ir6TJjS6+YKeCMKesJ7DXd5k2hMLBceSJ1QL9 gx/x5WjhQS/evPOrfjJthQaZsObDH2pXA0JykprM= Received: by simark.ca (Postfix, from userid 112) id 337871E105; Mon, 3 Mar 2025 10:00:21 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=sVmptsJd; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=VDkip9mk; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C314C1E08E for ; Mon, 3 Mar 2025 10:00:20 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6D3E9385801B for ; Mon, 3 Mar 2025 15:00:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6D3E9385801B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=sVmptsJd; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=VDkip9mk Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 3A91B3858D29 for ; Mon, 3 Mar 2025 14:59:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A91B3858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A91B3858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741013968; cv=none; b=HaXXLUMTJcqkZlKikrR7z8n5uHqi8c2+NXctS3dFbh8+urnSzRsM5pAOUlyKMsCjljJTxsibaSDu3JG2bUTyAi/y4NnlAfXjgGu0VWogywv8BbAERhDawL6YTdW6kAx6EHmAXEuphNuDrYJ/soIcraKhSA20KYu03b7zWL8ohEY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741013968; c=relaxed/simple; bh=1W1+iw17XjF8KpPnOaSLP44GmjQDyBkDRmBQa7kFUUM=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=txNRqLNkDeC5Qb7P0xABe9pd4M9AA9bpD4lGZ3uXWqEfcP2T+vuylfSMm/lkxYH6pEp7xVwUZ6xuAB4clcgCGYGsUHelEo68IIHqyX8zfk+MvVyk5TiOBnz7J06TdCEWkIK2RvW6Fh5fAZYQXjfGN98+lZH3YSTgloKPC3BLp/8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A91B3858D29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1741013967; bh=1W1+iw17XjF8KpPnOaSLP44GmjQDyBkDRmBQa7kFUUM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sVmptsJdHHB4maNPAYy3GyAA3z7TSHfOaPcpuQwmquPc3acni70O26TBgRzJC9O6J IxzJyxCg9PFE+far9EIiFY5vSbw9WcOMSRNNN/WWD+PpMc16iq1VYAFIMUgkWUCjH5 eimN4HYrqk5JClUBYIMsut9rpszNkttM6y36+lr0= Received: by simark.ca (Postfix, from userid 112) id E26C91E110; Mon, 3 Mar 2025 09:59:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1741013966; bh=1W1+iw17XjF8KpPnOaSLP44GmjQDyBkDRmBQa7kFUUM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=VDkip9mkXaIBxPTCrI6j4P/oMlKNyxxB47Y7O4nWQISTlUuXKCLw7VAvgsfc1ckIu 0X4hmuiS/KtWaITWQZ3IR2/5NfQmqIJGerlkk2KamBBFn8//4ZtVzyuWC6VhxX/0w4 KYTjHCZJPtrx6mRPhhTNu15V6QF6RrrOgBvGXC2s= Received: from [172.16.0.192] (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9B6ED1E08E; Mon, 3 Mar 2025 09:59:26 -0500 (EST) Message-ID: <9ab7816e-716b-432d-ac69-8c311ce2f38c@simark.ca> Date: Mon, 3 Mar 2025 09:59:25 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: add load-libthread-db-quietly option To: Eli Zaretskii , Gregory Heytings Cc: gdb-patches@sourceware.org References: <865xktq8gw.fsf@gnu.org> <8634fwq1sr.fsf@gnu.org> Content-Language: fr From: Simon Marchi In-Reply-To: <8634fwq1sr.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/1/25 9:10 AM, Eli Zaretskii wrote: >> Date: Sat, 01 Mar 2025 12:00:54 +0000 >> From: Gregory Heytings >> cc: Eli Zaretskii >> >> Thanks for the review! Updated patch attached. >> >>>> In line with the Unix tradition in which no messages are displayed when >>>> no error happens, I suggest the attached patch, with which users could >>>> "set load-libthread-db-quietly off" in their .gdbinit file. >>> >>> You mean, "on", right? Because "off" is the default. >>> >> >> Correct. >> >>> >>> There should be a NEWS entry about this new knob. >>> >> >> Now done. >> >>> >>> This description seems to be backwards, no? The option, when ON, causes >>> the messages NOT to be displayed, right? So I suggest >>> >>> Turns on or off quiet loading of @code{libthread_db}. When @code{on}, >>> @value{GDBN} loads @code{libthread_db} quietly, without any messages. >>> The default is @code{off}. >>> >> >> Also correct. > > Thanks, the documentation parts of this are approved. Now let's see > if the Powers that Be agree to the code changes... > > Reviewed-By: Eli Zaretskii People ask us to make it possible to turn this or that message on and off all the time. The proposed command, "set load-libthread-db-quietly", is very specific to that use case. Could we add perhaps a prefix command (or find an existing appropriate one) that would allow us to easily add more such knobs? I'm thinking of something like (maybe not a good name, but just for the example): (gdb) set message load-libthread-db on/off Simon