Re: [PATCH] gdb: add load-libthread-db-quietly option

[Eli Zaretskii <eliz@gnu.org>]

> Date: Sat, 01 Mar 2025 10:39:06 +0000
> From: Gregory Heytings <gregory@heytings.org>
> 
> In line with the Unix tradition in which no messages are displayed when no 
> error happens, I suggest the attached patch, with which users could "set 
> load-libthread-db-quietly off" in their .gdbinit file.

You mean, "on", right?  Because "off" is the default.

> Setting that option disables the "Thread debugging using libthread_db
> enabled" and "Using host libthread_db library..." messages.
> ---
>  gdb/doc/gdb.texinfo   |  7 +++++++
>  gdb/linux-thread-db.c | 29 ++++++++++++++++++++++++++---
>  2 files changed, 33 insertions(+), 3 deletions(-)

There should be a NEWS entry about this new knob.

> +@kindex set load-libthread-db-quietly
> +@kindex show load-libthread-db-quietly
> +@item set load-libthread-db-quietly
> +@itemx show load-libthread-db-quietly
> +Turns on or off display of messages when @code{libthread_db} is loaded.
> +The default is @code{off}.

This description seems to be backwards, no?  The option, when ON,
causes the messages NOT to be displayed, right?  So I suggest

  Turns on or off quiet loading of @code{libthread_db}.  When
  @code{on}, @value{GDBN} loads @code{libthread_db} quietly, without
  any messages.  The default is @code{off}.

Thanks.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>