From: Eli Zaretskii <eliz@gnu.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: add load-libthread-db-quietly option
Date: Sat, 01 Mar 2025 16:10:44 +0200 [thread overview]
Message-ID: <8634fwq1sr.fsf@gnu.org> (raw)
In-Reply-To: <d3de7625e40910da09b7@heytings.org> (message from Gregory Heytings on Sat, 01 Mar 2025 12:00:54 +0000)
> Date: Sat, 01 Mar 2025 12:00:54 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: Eli Zaretskii <eliz@gnu.org>
>
> Thanks for the review! Updated patch attached.
>
> >> In line with the Unix tradition in which no messages are displayed when
> >> no error happens, I suggest the attached patch, with which users could
> >> "set load-libthread-db-quietly off" in their .gdbinit file.
> >
> > You mean, "on", right? Because "off" is the default.
> >
>
> Correct.
>
> >
> > There should be a NEWS entry about this new knob.
> >
>
> Now done.
>
> >
> > This description seems to be backwards, no? The option, when ON, causes
> > the messages NOT to be displayed, right? So I suggest
> >
> > Turns on or off quiet loading of @code{libthread_db}. When @code{on},
> > @value{GDBN} loads @code{libthread_db} quietly, without any messages.
> > The default is @code{off}.
> >
>
> Also correct.
Thanks, the documentation parts of this are approved. Now let's see
if the Powers that Be agree to the code changes...
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2025-03-01 14:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-01 10:39 Gregory Heytings
2025-03-01 11:46 ` Eli Zaretskii
2025-03-01 12:00 ` Gregory Heytings
2025-03-01 14:10 ` Eli Zaretskii [this message]
2025-03-03 14:59 ` Simon Marchi
2025-03-03 15:04 ` Gregory Heytings
2025-03-03 15:26 ` Simon Marchi
2025-03-03 15:58 ` Gregory Heytings
2025-03-26 16:15 ` Tom Tromey
2025-03-26 16:38 ` Gregory Heytings
2025-03-03 15:40 ` Eli Zaretskii
2025-03-03 16:31 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8634fwq1sr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=gregory@heytings.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox