From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH 1/3] gdb/testsuite: missing ';' in check-all-boards rule
Date: Sat, 18 Jul 2026 12:27:25 +0100 [thread overview]
Message-ID: <93af307236959d9b9eb02cee73ca902028edc942.1784373976.git.aburgess@redhat.com> (raw)
In-Reply-To: <cover.1784373976.git.aburgess@redhat.com>
The check-all-boards makefile rule was missing a semicolon. As a
result we would pass "result=0" through to the make-check-all.sh
script.
This 'result=0' would end up inside the TESTS="..." string which was
passed to the 'make check-...' command. As 'result=0' doesn't match
any of GDB's .exp files the 'result=0' would then be ignored.
Back in the Makefile, due to the missing semicolon, as the
'result=...' line had become an extra argument to make-check-all.sh,
we were no longer capturing the exit status of the make-check-all.sh
script. This means that when the 'check-all-boards' rule completed we
actually exited with the exit status of the last command rather than
with the exit status of the make-check-all.sh script.
Fix this by adding in the missing semicolon.
There should be no changes in what is tested after this commit.
---
gdb/testsuite/Makefile.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
index f103d7ddd65..44c710f8de9 100644
--- a/gdb/testsuite/Makefile.in
+++ b/gdb/testsuite/Makefile.in
@@ -386,7 +386,7 @@ check-all-boards: all $(abs_builddir)/site.exp
${abs_srcdir}/make-check-all.sh --keep-results \
--host-user "$(GDB_HOST_USERNAME)" \
--target-user "$(GDB_TARGET_USERNAME)" \
- "$(TESTS)" \
+ "$(TESTS)"; \
result=$$?; \
if test -d check-all; then \
$(SHELL) $(srcdir)/../../contrib/dg-extract-results.sh \
--
2.25.4
next prev parent reply other threads:[~2026-07-18 11:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 11:27 [PATCH 0/3] Improvements to make-check-all.sh and check-all-boards Andrew Burgess
2026-07-18 11:27 ` Andrew Burgess [this message]
2026-07-18 11:27 ` [PATCH 2/3] gdb/testsuite: fix shellcheck issues in make-check-all.sh Andrew Burgess
2026-07-18 11:27 ` [PATCH 3/3] gdb/testsuite: improve rerun scripts generated by make-check-all.sh Andrew Burgess
2026-07-21 16:48 ` [PATCH 0/3] Improvements to make-check-all.sh and check-all-boards Tom Tromey
2026-07-23 16:42 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93af307236959d9b9eb02cee73ca902028edc942.1784373976.git.aburgess@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox