From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH 3/3] gdb/testsuite: improve rerun scripts generated by make-check-all.sh
Date: Sat, 18 Jul 2026 12:27:27 +0100 [thread overview]
Message-ID: <9cd9c53b7561d09ee1a6b18d0fce52b64ceb555c.1784373976.git.aburgess@redhat.com> (raw)
In-Reply-To: <cover.1784373976.git.aburgess@redhat.com>
The make-check-all.sh script creates little scripts that allow each
board to easily be rerun, useful if a particular test fails and you
want to check a possible fix.
The scripts as currently generated only include the 'make check-...'
line, and are not executable, which means you need to first change to
the correct directory, and invoke the script with 'sh'.
This commit extends the script to include a '#! /bin/sh' line as well
as a 'cd ....' line to switch to the correct directory to run the
test. The script is then made executable.
It should now be easier to rerun tests. There is no change to how
tests are run, or what tests are run with this commit.
---
gdb/testsuite/make-check-all.sh | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/make-check-all.sh b/gdb/testsuite/make-check-all.sh
index 3cf6b46cdb0..8708ecec1cc 100755
--- a/gdb/testsuite/make-check-all.sh
+++ b/gdb/testsuite/make-check-all.sh
@@ -215,8 +215,14 @@ do_tests ()
cp gdb.sum gdb.log "$dir"
# Record the 'make check' command to enable easy re-running.
- echo "make $maketarget RUNTESTFLAGS=\"${rtf[*]}\" TESTS=\"${tests[*]}\"" \
- > "$dir/make-check.sh"
+ make_check_script="$dir/make-check.sh"
+ cat <<-EOF > "$make_check_script"
+ #!/bin/sh
+
+ cd "$PWD" && \\
+ make $maketarget RUNTESTFLAGS="${rtf[*]}" TESTS="${tests[*]}"
+ EOF
+ chmod +x "$make_check_script"
fi
}
--
2.25.4
next prev parent reply other threads:[~2026-07-18 11:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 11:27 [PATCH 0/3] Improvements to make-check-all.sh and check-all-boards Andrew Burgess
2026-07-18 11:27 ` [PATCH 1/3] gdb/testsuite: missing ';' in check-all-boards rule Andrew Burgess
2026-07-18 11:27 ` [PATCH 2/3] gdb/testsuite: fix shellcheck issues in make-check-all.sh Andrew Burgess
2026-07-18 11:27 ` Andrew Burgess [this message]
2026-07-21 16:48 ` [PATCH 0/3] Improvements to make-check-all.sh and check-all-boards Tom Tromey
2026-07-23 16:42 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cd9c53b7561d09ee1a6b18d0fce52b64ceb555c.1784373976.git.aburgess@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox