Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH 2/3] gdb/testsuite: fix shellcheck issues in make-check-all.sh
Date: Sat, 18 Jul 2026 12:27:26 +0100	[thread overview]
Message-ID: <7a3d18d421045d093b31e49a0542852ff50a8288.1784373976.git.aburgess@redhat.com> (raw)
In-Reply-To: <cover.1784373976.git.aburgess@redhat.com>

Fix shellcheck issues in the make-check-all.sh script.  These are just
quoting issues, and should have no functional impact.

There should be no changes in what is tested after this commit.
---
 gdb/testsuite/make-check-all.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gdb/testsuite/make-check-all.sh b/gdb/testsuite/make-check-all.sh
index c46cd8de4ed..3cf6b46cdb0 100755
--- a/gdb/testsuite/make-check-all.sh
+++ b/gdb/testsuite/make-check-all.sh
@@ -320,7 +320,7 @@ main ()
     for b in "${target_boards[@]}"; do
 	echo "TARGET BOARD: $b"
 	rtf=(
-	    --target_board="$b"
+	    "--target_board=$b"
 	)
 	rtf_for_board "$b"
 	maketarget_for_board "$b"
@@ -332,7 +332,7 @@ main ()
     for b in "${gdbserver_boards[@]}" "${remote_gdbserver_boards[@]}"; do
 	echo "TARGET BOARD: $b"
 	rtf=(
-	    --target_board="$b"
+	    "--target_board=$b"
 	)
 	rtf_for_board "$b"
 	maketarget_for_board "$b"
@@ -345,8 +345,8 @@ main ()
 	for b in "${remote_gdbserver_boards[@]}"; do
 	    echo "HOST BOARD: $h, TARGET BOARD: $b"
 	    rtf=(
-		--host_board="$h"
-		--target_board="$b"
+		"--host_board=$h"
+		"--target_board=$b"
 	    )
 	    rtf_for_board "$h"
 	    rtf_for_board "$b"
@@ -360,8 +360,8 @@ main ()
     for b in "${host_target_boards[@]}"; do
 	echo "HOST/TARGET BOARD: $b"
 	rtf=(
-	    --host_board="$b"
-	    --target_board="$b"
+	    "--host_board=$b"
+	    "--target_board=$b"
 	)
 	rtf_for_board "$b"
 	maketarget_for_board "$b"
-- 
2.25.4


  parent reply	other threads:[~2026-07-18 11:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-18 11:27 [PATCH 0/3] Improvements to make-check-all.sh and check-all-boards Andrew Burgess
2026-07-18 11:27 ` [PATCH 1/3] gdb/testsuite: missing ';' in check-all-boards rule Andrew Burgess
2026-07-18 11:27 ` Andrew Burgess [this message]
2026-07-18 11:27 ` [PATCH 3/3] gdb/testsuite: improve rerun scripts generated by make-check-all.sh Andrew Burgess
2026-07-21 16:48 ` [PATCH 0/3] Improvements to make-check-all.sh and check-all-boards Tom Tromey
2026-07-23 16:42   ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a3d18d421045d093b31e49a0542852ff50a8288.1784373976.git.aburgess@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox