From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0VeAIE1jW2qa2BAAWB0awg (envelope-from ) for ; Sat, 18 Jul 2026 07:28:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GfC3mLPe; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7DF421E09E; Sat, 18 Jul 2026 07:28:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A117A1E099 for ; Sat, 18 Jul 2026 07:28:12 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 844264BA23D0 for ; Sat, 18 Jul 2026 11:28:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 844264BA23D0 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GfC3mLPe Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 0F4794BA2E13 for ; Sat, 18 Jul 2026 11:27:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F4794BA2E13 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0F4794BA2E13 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784374056; cv=none; b=FFx1SqRX1AceqO6aC64ktvXg1VhM9VrnD4ohgxqliMA3yXVCvOAtFXwXra8RoFWP8p6HPFUis1qItCPRzsEHG/66DvWhK7sqDgh591XLeFiUKQyzkX1NO+HQl8Kd9KL1QOxSWZUZTbxAMevpZP2pnLYLv8CjSKuL8xMe59sHm90= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784374056; c=relaxed/simple; bh=oaJTVbqCrGRsWelLY1qCCY+gVSjfMIMBUmZycVQPEvM=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=ACiCUXP5hvYTvh6lSoZ58yFy0w/Q0+qSximxMbyAoL7DN14GAMzdCnja5BrVfZ0QrTAobH14YwdAg4aDoePk8MB4JKaDf0dS6ZtSncAA/fRmIxyFeWLl6D26cBqY+7Ja3eIE8ugQkjE53r8LPqojR238WDMig+sFED9t8c4eQSQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GfC3mLPe DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0F4794BA2E13 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784374055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1p0fjuDSp9+D1vHZS9Q2cj/9plzZ74vP9dFVXoxxqqQ=; b=GfC3mLPe9tIb40xxSvWC5I84Qul6KjE/L9QhdKsgzt118mA3fZs+ZPBTPPlT09jZZphyHF tS9Z37l3wokpBcdTcTYZMROJQyn+rLzT6qc+rKTJ5+8RgU4/HLGFnBftRVquffKBoxsvNw S18C1MKAuPVWjd8Y6ZbxWcvBhBAqCvc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-7ithy07wPZaNx0Ar2yMsvg-1; Sat, 18 Jul 2026 07:27:33 -0400 X-MC-Unique: 7ithy07wPZaNx0Ar2yMsvg-1 X-Mimecast-MFC-AGG-ID: 7ithy07wPZaNx0Ar2yMsvg_1784374052 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4926fa2cb17so16649335e9.1 for ; Sat, 18 Jul 2026 04:27:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784374052; x=1784978852; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=1p0fjuDSp9+D1vHZS9Q2cj/9plzZ74vP9dFVXoxxqqQ=; b=bC5ogmI5X+5Z4DQ7/ZnEfKmVZyqg942bcnFICmnsQWkM8tawx3LSGPm/wY0JAePQI4 fopFVIXJmxT6pBr1AurlmCBJCUFj+476DbBxxTOKVhp9GrCzaLFNbId3kp7uWiiWkzgB drK54i8Mv9/Xe2h0POEL3nzfX5Eao7Jib3bGIo7j412vVVPK4k10UFIsgLWrPrzkfo7x bBR9iTEdIBXZKs5LmqdwJkbcc9qoSeSGlZBj36fVBx0MwM3vfpfZ96yerix8T7rYTXoM xTi1fgwpSwPNZcQtPlOP+ONewi70GB4okIJx6Afg42lBq0WJNJKAez39IPcWwfOXBseO x8hQ== X-Gm-Message-State: AOJu0YxPLgKzzrgiVszVhHEk1wvBRISvD+4qRierlTZhvhUgLM/5mV04 kIJ6F4+XSC3OlXCjDeFYDSKtc+8lfiWQiJdJMJ/BAvsCSqRm35UCVrJ2thFUgh7r4KFP0O3dH2j WMDDwJmg0KzKcQmlBSlsJkG9SCKRnNhbwZx0Gi7fvOIAsQbbX0grgSKNHXRl+3dFHPZBeDLRTp9 UKWTVFHa7j/e6D3q9rx7xRKsr+l2n7gyDu7y314aAUje5AD0E= X-Gm-Gg: AfdE7cl7dyzX6XM8z0XcjwKu5v5xgQvPPYOjKdIpoS/RnmS3ZuQiKXCfhkyW/0FF+BH 8cst8qTKuliODy1yO5Q2gh2tpKAANKVZrAscMBJkyvD+KpcVLt0jYeHhrC8YMPQ2Y1pFauQwMbo 3dn8NRGsY+8h68RQ8KIpbJqCjqbFO1zBXQX5VfpvfYEHuF52IAh8VjxQ3/7EpKML16Ngq+/Pgpm imGu+QhgtlXdd9h5bjxcy841PcqODwKc8jxLSEY4Z0QtI8Z9tdUYq5rg6J46tVH6gFB6JV/pcOd jG6UaSkOs2RX3XwttZXeOl75zCFazjrAwFSTTGZdu098Qea6ctbZPLCaQKa1UCMHrfwQKCAvngf FSz6d/DLSKrMHgxOI0BVXuUik X-Received: by 2002:a05:600c:3113:b0:493:f478:4c71 with SMTP id 5b1f17b1804b1-4954a323b14mr66136075e9.7.1784374052510; Sat, 18 Jul 2026 04:27:32 -0700 (PDT) X-Received: by 2002:a05:600c:3113:b0:493:f478:4c71 with SMTP id 5b1f17b1804b1-4954a323b14mr66135875e9.7.1784374052059; Sat, 18 Jul 2026 04:27:32 -0700 (PDT) Received: from localhost (92.40.184.195.threembb.co.uk. [92.40.184.195]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2692a3sm107210565e9.0.2026.07.18.04.27.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 04:27:31 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 1/3] gdb/testsuite: missing ';' in check-all-boards rule Date: Sat, 18 Jul 2026 12:27:25 +0100 Message-Id: <93af307236959d9b9eb02cee73ca902028edc942.1784373976.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: z0u7d0GLrmnxaJMEk4rZOvxYnGCrEoKlPjZVwPusGaw_1784374052 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The check-all-boards makefile rule was missing a semicolon. As a result we would pass "result=0" through to the make-check-all.sh script. This 'result=0' would end up inside the TESTS="..." string which was passed to the 'make check-...' command. As 'result=0' doesn't match any of GDB's .exp files the 'result=0' would then be ignored. Back in the Makefile, due to the missing semicolon, as the 'result=...' line had become an extra argument to make-check-all.sh, we were no longer capturing the exit status of the make-check-all.sh script. This means that when the 'check-all-boards' rule completed we actually exited with the exit status of the last command rather than with the exit status of the make-check-all.sh script. Fix this by adding in the missing semicolon. There should be no changes in what is tested after this commit. --- gdb/testsuite/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in index f103d7ddd65..44c710f8de9 100644 --- a/gdb/testsuite/Makefile.in +++ b/gdb/testsuite/Makefile.in @@ -386,7 +386,7 @@ check-all-boards: all $(abs_builddir)/site.exp ${abs_srcdir}/make-check-all.sh --keep-results \ --host-user "$(GDB_HOST_USERNAME)" \ --target-user "$(GDB_TARGET_USERNAME)" \ - "$(TESTS)" \ + "$(TESTS)"; \ result=$$?; \ if test -d check-all; then \ $(SHELL) $(srcdir)/../../contrib/dg-extract-results.sh \ -- 2.25.4