From: "Jim Blandy" <jimb@red-bean.com>
To: tromey@redhat.com
Cc: "Joel Brobecker" <brobecker@adacore.com>,
"Pedro Alves" <pedro@codesourcery.com>,
gdb-patches@sourceware.org
Subject: Re: RFA: Building GDB under GLIBC 2.8
Date: Tue, 06 Jan 2009 18:32:00 -0000 [thread overview]
Message-ID: <8f2776cb0901061032x12e863cco5ccda653b36be7dc@mail.gmail.com> (raw)
In-Reply-To: <m3ljtyzgte.fsf@fleche.redhat.com>
I've committed these two patches, with the suggestion made by Joel.
2009-01-06 Jim Blandy <jimb@red-bean.com>
Check return values of functions declared with warn_unused_result
attribute in GLIBC 2.8.
* cli/cli-cmds.c (pwd_command): Check return value from getcwd.
* inflow.c (check_syscall): New function.
(new_tty): Use check_syscall to check return values from open and dup.
* linux-nat.c (linux_nat_info_proc_cmd): Check return value from fgets.
* main.c (captured_main): Call cwd after setting up gdb_stderr;
check for errors from getcwd.
* mi/mi-cmd-env.c (mi_cmd_env_pwd): Check return value from getcwd.
* ui-file.c (stdio_file_write): Ignore return value from fwrite.
(stdio_file_fputs): Same.
* utils.c (internal_vproblem): abort if last-ditch error message
write fails.
* top.c (gdb_init): Don't set the current directory here; that's
already been done in captured_main.
prev parent reply other threads:[~2009-01-06 18:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 2:05 Jim Blandy
2008-12-13 20:33 ` Mark Kettenis
2008-12-13 23:02 ` Andreas Schwab
2008-12-14 6:08 ` Jim Blandy
2008-12-14 19:57 ` Mark Kettenis
2008-12-14 21:54 ` Paul Pluzhnikov
2008-12-14 18:26 ` Jan Kratochvil
2008-12-14 18:26 ` RFA: Building GDB under GLIBC 2.8 [resend w/the patch] Jan Kratochvil
2008-12-15 9:02 ` RFA: Building GDB under GLIBC 2.8 Jim Blandy
2008-12-15 20:07 ` Tom Tromey
2008-12-15 20:17 ` Pedro Alves
2008-12-20 0:46 ` Jim Blandy
2008-12-29 5:50 ` Joel Brobecker
2008-12-29 23:48 ` Tom Tromey
2009-01-06 18:32 ` Jim Blandy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f2776cb0901061032x12e863cco5ccda653b36be7dc@mail.gmail.com \
--to=jimb@red-bean.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox