From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21568 invoked by alias); 6 Jan 2009 18:32:41 -0000 Received: (qmail 21548 invoked by uid 22791); 6 Jan 2009 18:32:40 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from an-out-0708.google.com (HELO an-out-0708.google.com) (209.85.132.240) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Jan 2009 18:32:36 +0000 Received: by an-out-0708.google.com with SMTP id b38so2876438ana.3 for ; Tue, 06 Jan 2009 10:32:33 -0800 (PST) Received: by 10.142.177.7 with SMTP id z7mr9266331wfe.132.1231266753200; Tue, 06 Jan 2009 10:32:33 -0800 (PST) Received: by 10.142.211.13 with HTTP; Tue, 6 Jan 2009 10:32:33 -0800 (PST) Message-ID: <8f2776cb0901061032x12e863cco5ccda653b36be7dc@mail.gmail.com> Date: Tue, 06 Jan 2009 18:32:00 -0000 From: "Jim Blandy" To: tromey@redhat.com Subject: Re: RFA: Building GDB under GLIBC 2.8 Cc: "Joel Brobecker" , "Pedro Alves" , gdb-patches@sourceware.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <8f2776cb0812121804n1008f921h3898bb7bda1581c9@mail.gmail.com> <200812152016.56353.pedro@codesourcery.com> <8f2776cb0812191645m56a7bd29ob563ea7d4e79724b@mail.gmail.com> <20081229055001.GK4216@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00050.txt.bz2 I've committed these two patches, with the suggestion made by Joel. 2009-01-06 Jim Blandy Check return values of functions declared with warn_unused_result attribute in GLIBC 2.8. * cli/cli-cmds.c (pwd_command): Check return value from getcwd. * inflow.c (check_syscall): New function. (new_tty): Use check_syscall to check return values from open and dup. * linux-nat.c (linux_nat_info_proc_cmd): Check return value from fgets. * main.c (captured_main): Call cwd after setting up gdb_stderr; check for errors from getcwd. * mi/mi-cmd-env.c (mi_cmd_env_pwd): Check return value from getcwd. * ui-file.c (stdio_file_write): Ignore return value from fwrite. (stdio_file_fputs): Same. * utils.c (internal_vproblem): abort if last-ditch error message write fails. * top.c (gdb_init): Don't set the current directory here; that's already been done in captured_main.