Re: RFA: Building GDB under GLIBC 2.8

[Pedro Alves <pedro@codesourcery.com>]

On Saturday 13 December 2008 02:04:47, Jim Blandy wrote:
>         abort ();       /* NOTE: GDB has only three calls to abort().  */

                                                ^^^^^
<warning> incoming nit </warning>

Ooops, not three anymore, hey?  :-)

>        default:
>         dejavu = 3;
> -       write (STDERR_FILENO, msg, sizeof (msg));
> +        /* Newer GLIBC versions put the warn_unused_result attribute
> +           on write, but this is one of those rare cases where
> +           ignoring the return value is correct.  Casting to (void)
> +           does not fix this problem.  This is the solution suggested
> +           at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509.  */
> +       if (write (STDERR_FILENO, msg, sizeof (msg)) != sizeof (msg))
> +          abort ();
>         exit (1);
>        }

-- 
Pedro Alves