Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: "Jim Blandy" <jimb@red-bean.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Building GDB under GLIBC 2.8
Date: Mon, 15 Dec 2008 20:07:00 -0000	[thread overview]
Message-ID: <m3skopxkxa.fsf@fleche.redhat.com> (raw)
In-Reply-To: <8f2776cb0812121804n1008f921h3898bb7bda1581c9@mail.gmail.com> (Jim Blandy's message of "Fri\, 12 Dec 2008 18\:04\:47 -0800")

>>>>> "Jim" == Jim Blandy <jimb@red-bean.com> writes:

Jim> The latest version of Ubuntu (Intrepid Ibex) includes a GLIBC that
Jim> attaches the warn_unused_result attribute to many C library functions.
Jim>  The archer project doesn't use the -Wno-unused flag, so I needed to
Jim> fix these to build archer.  It seemed to me that submitting the patch
Jim> upstream would be the most helpful thing to do.

Thanks.

One nit from me:
 
Jim> +static void
Jim> +check_syscall (const char *msg, int result)
Jim> +{

I believe that these days we're asking for intro comments on all new
functions.

I can't approve or reject this, but according to MAINTAINERS, you can :)

Tom


  parent reply	other threads:[~2008-12-15 20:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-13  2:05 Jim Blandy
2008-12-13 20:33 ` Mark Kettenis
2008-12-13 23:02   ` Andreas Schwab
2008-12-14  6:08   ` Jim Blandy
2008-12-14 19:57     ` Mark Kettenis
2008-12-14 21:54       ` Paul Pluzhnikov
2008-12-14 18:26 ` Jan Kratochvil
2008-12-14 18:26   ` RFA: Building GDB under GLIBC 2.8 [resend w/the patch] Jan Kratochvil
2008-12-15  9:02   ` RFA: Building GDB under GLIBC 2.8 Jim Blandy
2008-12-15 20:07 ` Tom Tromey [this message]
2008-12-15 20:17 ` Pedro Alves
2008-12-20  0:46   ` Jim Blandy
2008-12-29  5:50     ` Joel Brobecker
2008-12-29 23:48       ` Tom Tromey
2009-01-06 18:32         ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3skopxkxa.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@red-bean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox