Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@red-bean.com>
To: gdb-patches@sourceware.org, Andrew STUBBS <andrew.stubbs@st.com>,
	 	Jim Blandy <jimb@red-bean.com>
Subject: Re: [RFC] Alternate approach to keeping convenience variables
Date: Mon, 23 Jan 2006 22:46:00 -0000	[thread overview]
Message-ID: <8f2776cb0601231446j3f962793ic4669b0b1aa5cecc@mail.gmail.com> (raw)
In-Reply-To: <20060122213118.GH27224@nevyn.them.org>

On 1/22/06, Daniel Jacobowitz <drow@false.org> wrote:
> This version of the patch addresses all the comments I've received,
> except for:
>
>   - TYPE_ZALLOC.  I think this is more appropriate as a macro,
>     personally, though I wouldn't argue too loudly if someone wanted to
>     functionify it at the same time as TYPE_ALLOC.

That's fine.  I'll have to put my typing where my mouth is.

>     GDB developers seem to have developed an allergy to C macros that
>     I just don't understand.  They're not _inherently_ obfuscating
>     or evil!  They can be both useful and elegant.

Nobody commented on my creative use of macros in m32c-tdep.c.  If I
were allergic, that'd definitely put me in anaphylactic shock.

I don't like TYPE_ZALLOC and TYPE_ALLOC because they don't get
anything special from being macros.  These aren't time-critical bits
of code.  They don't construct names.  They don't take a type as an
argument (err, a compile-time type, that is).  They don't expand to
statements.  They don't export an interface whose presence you'd like
to be able to test for easily at compile-time.  So why not get the
nicer syntax, type checking, and debuggability that functions provide?

De gustibus non est disputandum.


  reply	other threads:[~2006-01-23 22:46 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-21 22:05 [PATCH] keeping convenience variables (take 2) Andrew STUBBS
2005-11-22  4:58 ` Eli Zaretskii
2005-11-22  8:43 ` Jim Blandy
2005-11-22 19:27   ` Andrew STUBBS
2005-12-10  4:46     ` [RFC] Alternate approach to keeping convenience variables Daniel Jacobowitz
2005-12-10  5:07       ` Jim Blandy
2005-12-10  8:24         ` Daniel Jacobowitz
2005-12-10 22:20           ` Jim Blandy
2005-12-11 18:12             ` Eli Zaretskii
2005-12-11 19:17       ` Eli Zaretskii
2006-01-23 22:29         ` Jim Blandy
2006-01-24 11:44           ` Andrew STUBBS
2006-01-24 18:41             ` Jim Blandy
2006-01-24 18:43               ` Daniel Jacobowitz
2006-01-24 19:16                 ` Jim Blandy
2006-01-24 19:24                   ` Daniel Jacobowitz
2006-01-25  0:13                     ` Jim Blandy
2006-01-24 19:45                   ` Andrew STUBBS
2006-01-04 12:17       ` Andrew STUBBS
2006-01-04 17:00         ` Jim Blandy
2006-01-04 17:48           ` Andrew STUBBS
2006-01-04 18:37             ` Jim Blandy
2006-01-22 21:04               ` Daniel Jacobowitz
2006-01-22 21:31       ` Daniel Jacobowitz
2006-01-23 22:46         ` Jim Blandy [this message]
2006-01-27 17:53         ` Eli Zaretskii
2006-01-27 18:12           ` Jim Blandy
2006-01-27 18:29             ` Eli Zaretskii
2006-01-27 18:41           ` Joel Brobecker
2006-02-01 23:14         ` Daniel Jacobowitz
2006-02-02  4:18           ` Eli Zaretskii
2006-02-06 22:14             ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f2776cb0601231446j3f962793ic4669b0b1aa5cecc@mail.gmail.com \
    --to=jimb@red-bean.com \
    --cc=andrew.stubbs@st.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox