Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado <lgustavo@codesourcery.com>
To: John Baldwin <jhb@FreeBSD.org>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/4] Consistently use fprintf_filtered when displaying MIPS registers.
Date: Thu, 13 Apr 2017 16:29:00 -0000	[thread overview]
Message-ID: <8eadfc97-f4ec-8c89-f193-f96a2fa8839c@codesourcery.com> (raw)
In-Reply-To: <20170412183727.22483-4-jhb@FreeBSD.org>

On 04/12/2017 01:37 PM, John Baldwin wrote:
> One line was using printf_filtered instead of fprintf_filtered
> to the requested file.
>
> gdb/ChangeLog:
>
> 	* mips-tdep.c (print_gp_register_row): Replace printf_filtered
> 	with fprintf_filtered.
> ---
>  gdb/ChangeLog   | 5 +++++
>  gdb/mips-tdep.c | 2 +-
>  2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 73d24d2c9d..f1ac925fec 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,5 +1,10 @@
>  2017-04-11  John Baldwin  <jhb@FreeBSD.org>
>
> +	* mips-tdep.c (print_gp_register_row): Replace printf_filtered
> +	with fprintf_filtered.
> +
> +2017-04-11  John Baldwin  <jhb@FreeBSD.org>
> +
>  	* mips-fbsd-tdep.c (MIPS_PC_REGNUM): Remove.
>  	(MIPS_FP0_REGNUM): Remove.
>  	(MIPS_FSR_REGNUM): Remove.
> diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c
> index 41cb9d82c6..674b5098b0 100644
> --- a/gdb/mips-tdep.c
> +++ b/gdb/mips-tdep.c
> @@ -6539,7 +6539,7 @@ print_gp_register_row (struct ui_file *file, struct frame_info *frame,
>        for (byte = 0;
>  	   byte < (mips_abi_regsize (gdbarch)
>  		   - register_size (gdbarch, regnum)); byte++)
> -	printf_filtered ("  ");
> +	fprintf_filtered (file, "  ");
>        /* Now print the register value in hex, endian order.  */
>        if (gdbarch_byte_order (gdbarch) == BFD_ENDIAN_BIG)
>  	for (byte =
>

This one seems trivial enough. I have no comments.


  reply	other threads:[~2017-04-13 16:29 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12 18:37 [PATCH 0/4] Cleanups for MIPS registers (mostly FreeBSD-specific) John Baldwin
2017-04-12 18:37 ` [PATCH 1/4] Cleanups to FreeBSD/mips native register operations John Baldwin
2017-04-13 15:48   ` Luis Machado
2017-04-14 18:02     ` John Baldwin
2017-04-12 18:37 ` [PATCH 2/4] Use mips_regnum instead of constants for FreeBSD/mips " John Baldwin
2017-04-13 16:31   ` Luis Machado
2017-04-12 18:37 ` [PATCH 3/4] Consistently use fprintf_filtered when displaying MIPS registers John Baldwin
2017-04-13 16:29   ` Luis Machado [this message]
2017-04-27 16:05     ` Pedro Alves
2017-04-28 16:52       ` John Baldwin
2017-04-12 18:45 ` [PATCH 4/4] Don't throw an error in 'info registers' for unavailable MIPS GP registers John Baldwin
2017-04-13 16:37   ` Luis Machado
2017-04-14 18:02     ` John Baldwin
2017-04-15 16:02       ` Maciej W. Rozycki
2017-04-15 17:36         ` John Baldwin
2017-04-15 22:07           ` Maciej W. Rozycki
2017-04-17 18:27             ` John Baldwin
2017-04-18 21:33               ` Maciej W. Rozycki
2017-04-18 22:19                 ` John Baldwin
2017-04-25 21:02                   ` John Baldwin
2017-04-27  0:49                   ` Maciej W. Rozycki
2017-04-27 15:50                 ` Pedro Alves
2017-04-27 19:38                   ` Maciej W. Rozycki
2017-04-28 13:51                     ` Pedro Alves
2017-04-28 16:52                       ` John Baldwin
2017-05-05 19:51                         ` John Baldwin
2017-05-05 20:08                           ` Maciej W. Rozycki
2017-06-12 18:47                             ` John Baldwin
2017-06-15 23:50                               ` Maciej W. Rozycki
2017-06-16 16:17                                 ` John Baldwin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8eadfc97-f4ec-8c89-f193-f96a2fa8839c@codesourcery.com \
    --to=lgustavo@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jhb@FreeBSD.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox