Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: John Baldwin <jhb@FreeBSD.org>
To: gdb-patches@sourceware.org
Subject: [PATCH 4/4] Don't throw an error in 'info registers' for unavailable MIPS GP registers.
Date: Wed, 12 Apr 2017 18:45:00 -0000	[thread overview]
Message-ID: <20170412183727.22483-5-jhb@FreeBSD.org> (raw)
In-Reply-To: <20170412183727.22483-1-jhb@FreeBSD.org>

'info registers' for MIPS throws an error and when it first encounters
an unavailable register.  This does not match other architectures
which annotate unavailable registers and continue to print out the
values of subsequent registers.  Replace the error by displaying an
aligned "<unavailable>".  This string is truncated when displaying a
32-bit register.

gdb/ChangeLog:

	* mips-tdep.c (print_gp_register_row): Don't error for unavailable
	registers.
---
 gdb/ChangeLog   |  5 +++++
 gdb/mips-tdep.c | 10 ++++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index f1ac925fec..96a187667d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2017-04-11  John Baldwin  <jhb@FreeBSD.org>
 
+	* mips-tdep.c (print_gp_register_row): Don't error for unavailable
+	registers.
+
+2017-04-11  John Baldwin  <jhb@FreeBSD.org>
+
 	* mips-tdep.c (print_gp_register_row): Replace printf_filtered
 	with fprintf_filtered.
 
diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c
index 674b5098b0..4ec0c31341 100644
--- a/gdb/mips-tdep.c
+++ b/gdb/mips-tdep.c
@@ -6533,8 +6533,14 @@ print_gp_register_row (struct ui_file *file, struct frame_info *frame,
 
       /* OK: get the data in raw format.  */
       if (!deprecated_frame_register_read (frame, regnum, raw_buffer))
-	error (_("can't read register %d (%s)"),
-	       regnum, gdbarch_register_name (gdbarch, regnum));
+	{
+	  fprintf_filtered (file, "%*.*s ",
+			    (int) mips_abi_regsize (gdbarch) * 2,
+			    (int) mips_abi_regsize (gdbarch) * 2,
+			    "<unavailable>");
+	  col++;
+	  continue;
+	}
       /* pad small registers */
       for (byte = 0;
 	   byte < (mips_abi_regsize (gdbarch)
-- 
2.11.0


  parent reply	other threads:[~2017-04-12 18:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12 18:37 [PATCH 0/4] Cleanups for MIPS registers (mostly FreeBSD-specific) John Baldwin
2017-04-12 18:37 ` [PATCH 2/4] Use mips_regnum instead of constants for FreeBSD/mips register operations John Baldwin
2017-04-13 16:31   ` Luis Machado
2017-04-12 18:37 ` [PATCH 1/4] Cleanups to FreeBSD/mips native " John Baldwin
2017-04-13 15:48   ` Luis Machado
2017-04-14 18:02     ` John Baldwin
2017-04-12 18:37 ` [PATCH 3/4] Consistently use fprintf_filtered when displaying MIPS registers John Baldwin
2017-04-13 16:29   ` Luis Machado
2017-04-27 16:05     ` Pedro Alves
2017-04-28 16:52       ` John Baldwin
2017-04-12 18:45 ` John Baldwin [this message]
2017-04-13 16:37   ` [PATCH 4/4] Don't throw an error in 'info registers' for unavailable MIPS GP registers Luis Machado
2017-04-14 18:02     ` John Baldwin
2017-04-15 16:02       ` Maciej W. Rozycki
2017-04-15 17:36         ` John Baldwin
2017-04-15 22:07           ` Maciej W. Rozycki
2017-04-17 18:27             ` John Baldwin
2017-04-18 21:33               ` Maciej W. Rozycki
2017-04-18 22:19                 ` John Baldwin
2017-04-25 21:02                   ` John Baldwin
2017-04-27  0:49                   ` Maciej W. Rozycki
2017-04-27 15:50                 ` Pedro Alves
2017-04-27 19:38                   ` Maciej W. Rozycki
2017-04-28 13:51                     ` Pedro Alves
2017-04-28 16:52                       ` John Baldwin
2017-05-05 19:51                         ` John Baldwin
2017-05-05 20:08                           ` Maciej W. Rozycki
2017-06-12 18:47                             ` John Baldwin
2017-06-15 23:50                               ` Maciej W. Rozycki
2017-06-16 16:17                                 ` John Baldwin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170412183727.22483-5-jhb@FreeBSD.org \
    --to=jhb@freebsd.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox