Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@imgtec.com>
To: John Baldwin <jhb@freebsd.org>
Cc: Luis Machado <lgustavo@codesourcery.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 4/4] Don't throw an error in 'info registers' for unavailable MIPS GP registers.
Date: Sat, 15 Apr 2017 16:02:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.00.1704151651360.25796@tp.orcam.me.uk> (raw)
In-Reply-To: <2093712.xnU824ggfa@ralph.baldwin.cx>

On Fri, 14 Apr 2017, John Baldwin wrote:

> > What is the output you're getting in this case?
> 
> On FreeBSD (which doesn't support fir) I now get this:

 If the register is not ever supplied, then you need a target description 
that does not include it.  The rest of code will then handle it correctly.

> It was more dire on a target that doesn't supply all registers.  For example,
> I have an out of tree target for FreeBSD kernels and stopped threads in
> FreeBSD's kernel only supply a subset of GPRs.  Without the patch examining
> registers for a stopped thread looks like this:

 Why can't the remaining general registers be read or written -- is that a 
bug in the kernel?

 That sort of defeats the point of debugging, where you'd expect to be 
able to poke at any register that is at debuggee's disposal (so not 
supplying FIR can be considered a bug too).  A program's variable could 
live in such an inaccessible register for example.

 I'll see if there's anything else I want to comment on in this series 
next week.

  Maciej


  reply	other threads:[~2017-04-15 16:02 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12 18:37 [PATCH 0/4] Cleanups for MIPS registers (mostly FreeBSD-specific) John Baldwin
2017-04-12 18:37 ` [PATCH 3/4] Consistently use fprintf_filtered when displaying MIPS registers John Baldwin
2017-04-13 16:29   ` Luis Machado
2017-04-27 16:05     ` Pedro Alves
2017-04-28 16:52       ` John Baldwin
2017-04-12 18:37 ` [PATCH 2/4] Use mips_regnum instead of constants for FreeBSD/mips register operations John Baldwin
2017-04-13 16:31   ` Luis Machado
2017-04-12 18:37 ` [PATCH 1/4] Cleanups to FreeBSD/mips native " John Baldwin
2017-04-13 15:48   ` Luis Machado
2017-04-14 18:02     ` John Baldwin
2017-04-12 18:45 ` [PATCH 4/4] Don't throw an error in 'info registers' for unavailable MIPS GP registers John Baldwin
2017-04-13 16:37   ` Luis Machado
2017-04-14 18:02     ` John Baldwin
2017-04-15 16:02       ` Maciej W. Rozycki [this message]
2017-04-15 17:36         ` John Baldwin
2017-04-15 22:07           ` Maciej W. Rozycki
2017-04-17 18:27             ` John Baldwin
2017-04-18 21:33               ` Maciej W. Rozycki
2017-04-18 22:19                 ` John Baldwin
2017-04-25 21:02                   ` John Baldwin
2017-04-27  0:49                   ` Maciej W. Rozycki
2017-04-27 15:50                 ` Pedro Alves
2017-04-27 19:38                   ` Maciej W. Rozycki
2017-04-28 13:51                     ` Pedro Alves
2017-04-28 16:52                       ` John Baldwin
2017-05-05 19:51                         ` John Baldwin
2017-05-05 20:08                           ` Maciej W. Rozycki
2017-06-12 18:47                             ` John Baldwin
2017-06-15 23:50                               ` Maciej W. Rozycki
2017-06-16 16:17                                 ` John Baldwin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1704151651360.25796@tp.orcam.me.uk \
    --to=macro@imgtec.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jhb@freebsd.org \
    --cc=lgustavo@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox