From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121887 invoked by alias); 13 Apr 2017 16:29:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121877 invoked by uid 89); 13 Apr 2017 16:29:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Apr 2017 16:29:44 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cyhcu-0005y8-Rt from Luis_Gustavo@mentor.com ; Thu, 13 Apr 2017 09:29:44 -0700 Received: from [172.30.1.10] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 13 Apr 2017 09:29:41 -0700 Subject: Re: [PATCH 3/4] Consistently use fprintf_filtered when displaying MIPS registers. References: <20170412183727.22483-1-jhb@FreeBSD.org> <20170412183727.22483-4-jhb@FreeBSD.org> To: John Baldwin , Reply-To: Luis Machado From: Luis Machado Message-ID: <8eadfc97-f4ec-8c89-f193-f96a2fa8839c@codesourcery.com> Date: Thu, 13 Apr 2017 16:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170412183727.22483-4-jhb@FreeBSD.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-08.mgc.mentorg.com (147.34.90.208) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00442.txt.bz2 On 04/12/2017 01:37 PM, John Baldwin wrote: > One line was using printf_filtered instead of fprintf_filtered > to the requested file. > > gdb/ChangeLog: > > * mips-tdep.c (print_gp_register_row): Replace printf_filtered > with fprintf_filtered. > --- > gdb/ChangeLog | 5 +++++ > gdb/mips-tdep.c | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 73d24d2c9d..f1ac925fec 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,5 +1,10 @@ > 2017-04-11 John Baldwin > > + * mips-tdep.c (print_gp_register_row): Replace printf_filtered > + with fprintf_filtered. > + > +2017-04-11 John Baldwin > + > * mips-fbsd-tdep.c (MIPS_PC_REGNUM): Remove. > (MIPS_FP0_REGNUM): Remove. > (MIPS_FSR_REGNUM): Remove. > diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c > index 41cb9d82c6..674b5098b0 100644 > --- a/gdb/mips-tdep.c > +++ b/gdb/mips-tdep.c > @@ -6539,7 +6539,7 @@ print_gp_register_row (struct ui_file *file, struct frame_info *frame, > for (byte = 0; > byte < (mips_abi_regsize (gdbarch) > - register_size (gdbarch, regnum)); byte++) > - printf_filtered (" "); > + fprintf_filtered (file, " "); > /* Now print the register value in hex, endian order. */ > if (gdbarch_byte_order (gdbarch) == BFD_ENDIAN_BIG) > for (byte = > This one seems trivial enough. I have no comments.