Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Paul Pluzhnikov <ppluzhnikov@google.com>
To: gdb-patches ml <gdb-patches@sourceware.org>
Cc: Christian Thalinger <Christian.Thalinger@sun.com>,
	        Paul Pluzhnikov <ppluzhnikov@google.com>
Subject: Re: [patch] Fix Darwin breakage
Date: Fri, 14 Aug 2009 17:56:00 -0000	[thread overview]
Message-ID: <8ac60eac0908141038q4e33081ayf7142aef56816352@mail.gmail.com> (raw)
In-Reply-To: <8ac60eac0908140922m57367e9dn464783d8ff625474@mail.gmail.com>

On Fri, Aug 14, 2009 at 9:22 AM, Paul Pluzhnikov<ppluzhnikov@google.com> wrote:

> Here is a proposed fix.

I just realized that I should probably also turn OBJF_NOT_MAPPED
for separate debuginfo files like this:

Index: symfile.c
===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.241
diff -u -p -u -r1.241 symfile.c
--- symfile.c   10 Aug 2009 22:09:22 -0000      1.241
+++ symfile.c   14 Aug 2009 17:32:33 -0000
@@ -2534,8 +2534,9 @@ reread_separate_symbols (struct objfile
             info_verbose ? SYMFILE_VERBOSE : 0,
             0, /* No addr table.  */
             objfile->section_offsets, objfile->num_sections,
-            objfile->flags & (OBJF_REORDERED | OBJF_SHARED | OBJF_READNOW
-                              | OBJF_USERLOADED)));
+            (objfile->flags & (OBJF_REORDERED | OBJF_SHARED | OBJF_READNOW
+                              | OBJF_USERLOADED)
+            | OBJF_NOT_MAPPED));
       objfile->separate_debug_objfile->separate_debug_objfile_backlink
         = objfile;
     }

so I don't have to sort/eliminate duplicates later in objfiles.c
update_section_map, and audit other places (if any) where
symbol_file_add* routines are called as well.

I'll do that, if the initial patch is deemed roughly correct.

Thanks,
-- 
Paul Pluzhnikov


  reply	other threads:[~2009-08-14 17:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-14 16:32 Paul Pluzhnikov
2009-08-14 17:56 ` Paul Pluzhnikov [this message]
2009-08-14 19:09   ` Tom Tromey
2009-08-14 18:32 ` Tom Tromey
2009-08-14 19:15   ` Paul Pluzhnikov
2009-08-18 12:24 ` Christian Thalinger
2009-08-18 16:17   ` Paul Pluzhnikov
2009-08-20 17:01     ` Christian Thalinger
2009-08-20 17:09       ` Paul Pluzhnikov
2009-08-20 17:16         ` Christian Thalinger
2009-08-21 11:30         ` Christian Thalinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ac60eac0908141038q4e33081ayf7142aef56816352@mail.gmail.com \
    --to=ppluzhnikov@google.com \
    --cc=Christian.Thalinger@sun.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox