Re: [patch] Fix Darwin breakage

Paul Pluzhnikov
2009-08-14T19:09:43Z

On Fri, Aug 14, 2009 at 11:30 AM, Tom Tromey<tromey@redhat.com> wrote:

> The idea seems reasonable enough to me, but I don't really understand
> all the implications of it. If we need special treatment here, why not
> in all the other places that use ALL_OBJSECTIONS and the like?

Good question.

I looked in gcore.c, and it looks like it should similarly skip
OBJF_NOT_MAPPED objfiles.

In main.c, I am not sure, but possibly.

In printcmd.c, it's already skipping some (but not all!):

ALL_OBJSECTIONS (objfile, osect)
{
/* Only process each object file once, even if there's a separate
debug file. */
if (objfile->separate_debug_objfile_backlink)
continue;

In spu-tdep.c and symfile.c all uses have to do with overlays,
and I *think* they should similarly skip.

On Fri, Aug 14, 2009 at 11:32 AM, Tom Tromey<tromey@redhat.com> wrote:

> I think you probably would also need to do this in
> symbol_file_add_with_addrs_or_offsets.

Right, that's what '*' in 'symbol_file_add*' was supposed to convey.
Perhaps I should have used regexp instead of shell glob :-)

Thanks,
--
Paul Pluzhnikov