From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-65999-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12112 invoked by alias); 14 Aug 2009 17:38:56 -0000
Received: (qmail 12053 invoked by uid 22791); 14 Aug 2009 17:38:56 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Aug 2009 17:38:51 +0000
Received: from zps76.corp.google.com (zps76.corp.google.com [172.25.146.76]) 	by smtp-out.google.com with ESMTP id n7EHck4X009683 	for <gdb-patches@sourceware.org>; Fri, 14 Aug 2009 18:38:47 +0100
Received: from rv-out-0708.google.com (rvfc5.prod.google.com [10.140.180.5]) 	by zps76.corp.google.com with ESMTP id n7EHcTMQ023102 	for <gdb-patches@sourceware.org>; Fri, 14 Aug 2009 10:38:44 -0700
Received: by rv-out-0708.google.com with SMTP id c5so422080rvf.54         for <gdb-patches@sourceware.org>; Fri, 14 Aug 2009 10:38:44 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.140.162.20 with SMTP id k20mr1070885rve.255.1250271524188;  	Fri, 14 Aug 2009 10:38:44 -0700 (PDT)
In-Reply-To: <8ac60eac0908140922m57367e9dn464783d8ff625474@mail.gmail.com>
References: <8ac60eac0908140922m57367e9dn464783d8ff625474@mail.gmail.com>
Date: Fri, 14 Aug 2009 17:56:00 -0000
Message-ID: <8ac60eac0908141038q4e33081ayf7142aef56816352@mail.gmail.com>
Subject: Re: [patch] Fix Darwin breakage
From: Paul Pluzhnikov <ppluzhnikov@google.com>
To: gdb-patches ml <gdb-patches@sourceware.org>
Cc: Christian Thalinger <Christian.Thalinger@sun.com>,         Paul Pluzhnikov <ppluzhnikov@google.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-08/txt/msg00198.txt.bz2

On Fri, Aug 14, 2009 at 9:22 AM, Paul Pluzhnikov<ppluzhnikov@google.com> wrote:

> Here is a proposed fix.

I just realized that I should probably also turn OBJF_NOT_MAPPED
for separate debuginfo files like this:

Index: symfile.c
===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.241
diff -u -p -u -r1.241 symfile.c
--- symfile.c   10 Aug 2009 22:09:22 -0000      1.241
+++ symfile.c   14 Aug 2009 17:32:33 -0000
@@ -2534,8 +2534,9 @@ reread_separate_symbols (struct objfile
             info_verbose ? SYMFILE_VERBOSE : 0,
             0, /* No addr table.  */
             objfile->section_offsets, objfile->num_sections,
-            objfile->flags & (OBJF_REORDERED | OBJF_SHARED | OBJF_READNOW
-                              | OBJF_USERLOADED)));
+            (objfile->flags & (OBJF_REORDERED | OBJF_SHARED | OBJF_READNOW
+                              | OBJF_USERLOADED)
+            | OBJF_NOT_MAPPED));
       objfile->separate_debug_objfile->separate_debug_objfile_backlink
         = objfile;
     }

so I don't have to sort/eliminate duplicates later in objfiles.c
update_section_map, and audit other places (if any) where
symbol_file_add* routines are called as well.

I'll do that, if the initial patch is deemed roughly correct.

Thanks,
-- 
Paul Pluzhnikov