From: Paul Pluzhnikov <ppluzhnikov@google.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [rfc][patch] Eliminate quadratic slow-down on number of solibs.
Date: Mon, 22 Jun 2009 19:42:00 -0000 [thread overview]
Message-ID: <8ac60eac0906221242o56529b23s600d18e0cb69eb45@mail.gmail.com> (raw)
In-Reply-To: <200906221928.n5MJSivT013948@d12av02.megacenter.de.ibm.com>
On Mon, Jun 22, 2009 at 12:28 PM, Ulrich Weigand<uweigand@de.ibm.com> wrote:
> In any case, I don't think your patch fixes the problem in the case
> where more than one objfile defines _ovly_debug_event:
Yes, I realized that soon after posting the patch as well :-(
> In fact, I don't really see an easy way to identify the originating
> objfile just from looking at the breakpoint. Maybe we could set addr_string
> to some string that uniquely identifies the objfile when creating the
> breakpoint? It isn't really used for a lot else for bp_overlay_event
> breakpoints (except for the maint info breakpoint output).
Perhaps a better alternative is to restore the overlay-bp-reset behavior to
"before 2009-05-12" commit: now that this change is in:
2009-06-16 Paul Pluzhnikov <ppluzhnikov@google.com>
* solib.c (symbol_add_stub): New FLAGS parameter.
...
(solib_add): Defer breakpoint_re_set until after all solibs.
the 2009-05-12 change (I believe -- I'd need to verify that) should no
longer make any difference.
Thanks,
--
Paul Pluzhnikov
next prev parent reply other threads:[~2009-06-22 19:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 23:29 Paul Pluzhnikov
2009-04-21 1:06 ` Tom Tromey
2009-04-29 21:12 ` Paul Pluzhnikov
2009-05-12 8:48 ` Joel Brobecker
2009-05-12 21:21 ` Paul Pluzhnikov
2009-05-13 9:39 ` Joel Brobecker
2009-06-22 17:10 ` Ulrich Weigand
2009-06-22 18:56 ` Paul Pluzhnikov
2009-06-22 19:30 ` Ulrich Weigand
2009-06-22 19:42 ` Paul Pluzhnikov [this message]
2009-06-22 20:06 ` Ulrich Weigand
2009-06-22 22:04 ` Paul Pluzhnikov
2009-06-23 0:43 ` Ulrich Weigand
2009-06-23 1:33 ` Paul Pluzhnikov
2009-06-23 13:32 ` Ulrich Weigand
2009-06-22 20:41 ` Doug Evans
2009-06-22 20:48 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ac60eac0906221242o56529b23s600d18e0cb69eb45@mail.gmail.com \
--to=ppluzhnikov@google.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox