Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [rfc][patch] Eliminate quadratic slow-down on number of solibs.
Date: Tue, 12 May 2009 08:48:00 -0000	[thread overview]
Message-ID: <20090512084801.GA25263@adacore.com> (raw)
In-Reply-To: <8ac60eac0904291411o4666b3eha30d95cc88811dd5@mail.gmail.com>

> 2009-04-29  Paul Pluzhnikov  <ppluzhnikov@google.com>
> 
> 	* breakpoint.h: Add breakpoint_re_set_objfile prototype.
> 
> 	* breakpoint.c (breakpoint_re_set_objfile): Don't rescan
> 	all objfiles unnecessarily.
> 	(breakpoint_re_set): New function.
> 
> 	* symfile.c (new_symfile_objfile): Call breakpoint_re_set_objfile
> 	instead of breakpoint_re_set.
> 
> 	* objfiles.c (objfile_relocate): Likewise.

Looks OK to me.

Perhaps we could get rid of create_overlay_event_breakpoint entirely
by inlining it at the only location where it remains in use, and then
we can rename create_overlay_event_breakpoint_1 back to
create_overlay_event_breakpoint. Just thinking out loud, not that
it matters very much; it's just that, if it is potentially expensive
to call create_overlay_event_breakpoint because it iterates over
all objfiles, it might be beneficial to make this apparent by forcing
the caller to do the iteration (one line of code).

-- 
Joel


  reply	other threads:[~2009-05-12  8:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-20 23:29 Paul Pluzhnikov
2009-04-21  1:06 ` Tom Tromey
2009-04-29 21:12   ` Paul Pluzhnikov
2009-05-12  8:48     ` Joel Brobecker [this message]
2009-05-12 21:21       ` Paul Pluzhnikov
2009-05-13  9:39         ` Joel Brobecker
2009-06-22 17:10         ` Ulrich Weigand
2009-06-22 18:56           ` Paul Pluzhnikov
2009-06-22 19:30             ` Ulrich Weigand
2009-06-22 19:42               ` Paul Pluzhnikov
2009-06-22 20:06                 ` Ulrich Weigand
2009-06-22 22:04                   ` Paul Pluzhnikov
2009-06-23  0:43                     ` Ulrich Weigand
2009-06-23  1:33                       ` Paul Pluzhnikov
2009-06-23 13:32                         ` Ulrich Weigand
2009-06-22 20:41             ` Doug Evans
2009-06-22 20:48               ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090512084801.GA25263@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ppluzhnikov@google.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox