From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7008 invoked by alias); 22 Jun 2009 19:42:54 -0000 Received: (qmail 7000 invoked by uid 22791); 22 Jun 2009 19:42:54 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Jun 2009 19:42:48 +0000 Received: from zps19.corp.google.com (zps19.corp.google.com [172.25.146.19]) by smtp-out.google.com with ESMTP id n5MJghFh008725 for ; Mon, 22 Jun 2009 20:42:44 +0100 Received: from qyk26 (qyk26.prod.google.com [10.241.83.154]) by zps19.corp.google.com with ESMTP id n5MJgfLL019107 for ; Mon, 22 Jun 2009 12:42:41 -0700 Received: by qyk26 with SMTP id 26so4210283qyk.1 for ; Mon, 22 Jun 2009 12:42:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.85.17 with SMTP id m17mr1243851qcl.43.1245699760963; Mon, 22 Jun 2009 12:42:40 -0700 (PDT) In-Reply-To: <200906221928.n5MJSivT013948@d12av02.megacenter.de.ibm.com> References: <8ac60eac0906221156o91c8059t17d1dd1bd2752dd0@mail.gmail.com> <200906221928.n5MJSivT013948@d12av02.megacenter.de.ibm.com> Date: Mon, 22 Jun 2009 19:42:00 -0000 Message-ID: <8ac60eac0906221242o56529b23s600d18e0cb69eb45@mail.gmail.com> Subject: Re: [rfc][patch] Eliminate quadratic slow-down on number of solibs. From: Paul Pluzhnikov To: Ulrich Weigand Cc: Joel Brobecker , tromey@redhat.com, gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00581.txt.bz2 On Mon, Jun 22, 2009 at 12:28 PM, Ulrich Weigand wrote: > In any case, I don't think your patch fixes the problem in the case > where more than one objfile defines _ovly_debug_event: Yes, I realized that soon after posting the patch as well :-( > In fact, I don't really see an easy way to identify the originating > objfile just from looking at the breakpoint. =A0Maybe we could set addr_s= tring > to some string that uniquely identifies the objfile when creating the > breakpoint? =A0It isn't really used for a lot else for bp_overlay_event > breakpoints (except for the maint info breakpoint output). Perhaps a better alternative is to restore the overlay-bp-reset behavior to "before 2009-05-12" commit: now that this change is in: 2009-06-16 Paul Pluzhnikov * solib.c (symbol_add_stub): New FLAGS parameter. ... (solib_add): Defer breakpoint_re_set until after all solibs. the 2009-05-12 change (I believe -- I'd need to verify that) should no longer make any difference. Thanks, --=20 Paul Pluzhnikov