From: Paul Pluzhnikov <ppluzhnikov@google.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] fix thinko in sym info
Date: Thu, 20 Nov 2008 02:06:00 -0000 [thread overview]
Message-ID: <8ac60eac0811191502r637cc72en87554285734a5911@mail.gmail.com> (raw)
In-Reply-To: <20081119225237.1D8751C799D@localhost>
On Wed, Nov 19, 2008 at 2:52 PM, Doug Evans <dje@google.com> wrote:
> asm-source.exp is now failing because it doesn't expect the offset
> to be printed if its zero.
> One could update the testcase, but the old behaviour is more user-friendly.
Hmm, why didn't I notice this failure ...
It's UNTESTED for me both before and after. I'll investigate why.
> The outstanding question is, of course, whether
> "%s + %u", msym_name, offset
> needs i18n. This patch assumes it doesn't.
From: http://sourceware.org/ml/gdb-patches/2008-11/msg00378.html
In addition, translating each part without seeing the whole
sentence is very difficult.
I didn't want to add 8 more clauses to this if statement.
Regards,
--
Paul Pluzhnikov
next prev parent reply other threads:[~2008-11-19 23:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 2:03 Doug Evans
2008-11-20 2:06 ` Paul Pluzhnikov [this message]
2008-11-20 2:08 ` Doug Evans
2008-11-20 2:10 ` Joel Brobecker
2008-11-20 8:46 ` Eli Zaretskii
2008-11-20 14:33 ` Pedro Alves
[not found] ` <e394668d0811192213u7c5edd9fr2e243d8699b0a632@mail.gmail.com>
2008-11-21 1:42 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ac60eac0811191502r637cc72en87554285734a5911@mail.gmail.com \
--to=ppluzhnikov@google.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox