From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Doug Evans <dje@google.com>, ppluzhnikov@google.com
Subject: Re: [RFA] fix thinko in sym info
Date: Thu, 20 Nov 2008 14:33:00 -0000 [thread overview]
Message-ID: <200811200554.46138.pedro@codesourcery.com> (raw)
In-Reply-To: <20081119225237.1D8751C799D@localhost>
This should be:
> + if (offset)
> + xasprintf (&loc_string, "%s + %u", msym_name, offset);
> + else
> + xasprintf (&loc_string, "%s", msym_name);
> +
... = make_cleanup (xfree, loc_string);
> + free (loc_string);
do_cleanups (...);
> }
... instead of raw 'free'.
The easiest exception you can get here, is if the user quits on a
pagination request inside print_filtered.
There, see, a huge leak is plugged fixed. :-)
(would be s/free/xfree/, btw.)
Other than that, it also looks good to me.
I'd say, go ahead!
--
Pedro Alves
next prev parent reply other threads:[~2008-11-20 5:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 2:03 Doug Evans
2008-11-20 2:06 ` Paul Pluzhnikov
2008-11-20 2:08 ` Doug Evans
2008-11-20 2:10 ` Joel Brobecker
2008-11-20 8:46 ` Eli Zaretskii
2008-11-20 14:33 ` Pedro Alves [this message]
[not found] ` <e394668d0811192213u7c5edd9fr2e243d8699b0a632@mail.gmail.com>
2008-11-21 1:42 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811200554.46138.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox