From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10700 invoked by alias); 20 Nov 2008 05:56:04 -0000 Received: (qmail 10636 invoked by uid 22791); 20 Nov 2008 05:56:03 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Nov 2008 05:54:46 +0000 Received: (qmail 31589 invoked from network); 20 Nov 2008 05:54:44 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 20 Nov 2008 05:54:44 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] fix thinko in sym info Date: Thu, 20 Nov 2008 14:33:00 -0000 User-Agent: KMail/1.9.10 Cc: Doug Evans , ppluzhnikov@google.com References: <20081119225237.1D8751C799D@localhost> In-Reply-To: <20081119225237.1D8751C799D@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Content-Disposition: inline Message-Id: <200811200554.46138.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00542.txt.bz2 VGhpcyBzaG91bGQgYmU6Cgo+ICvCoMKgwqDCoMKgwqDCoGlmIChvZmZzZXQp Cj4gK8KgwqDCoMKgwqDCoMKgIMKgeGFzcHJpbnRmICgmbG9jX3N0cmluZywg IiVzICsgJXUiLCBtc3ltX25hbWUsIG9mZnNldCk7Cj4gK8KgwqDCoMKgwqDC oMKgZWxzZQo+ICvCoMKgwqDCoMKgwqDCoCDCoHhhc3ByaW50ZiAoJmxvY19z dHJpbmcsICIlcyIsIG1zeW1fbmFtZSk7Cj4gKwoKICAgICAgICAuLi4gPSBt YWtlX2NsZWFudXAgKHhmcmVlLCBsb2Nfc3RyaW5nKTsKCgo+ICvCoMKgwqDC oMKgwqDCoGZyZWUgKGxvY19zdHJpbmcpOwoKICAgICAgICBkb19jbGVhbnVw cyAoLi4uKTsKCj4gwqAgwqAgwqAgwqB9CgouLi4gaW5zdGVhZCBvZiByYXcg J2ZyZWUnLgoKVGhlIGVhc2llc3QgZXhjZXB0aW9uIHlvdSBjYW4gZ2V0IGhl cmUsIGlzIGlmIHRoZSB1c2VyIHF1aXRzIG9uIGEKcGFnaW5hdGlvbiByZXF1 ZXN0IGluc2lkZSBwcmludF9maWx0ZXJlZC4KClRoZXJlLCBzZWUsIGEgaHVn ZSBsZWFrIGlzIHBsdWdnZWQgZml4ZWQuICA6LSkKCih3b3VsZCBiZSBzL2Zy ZWUveGZyZWUvLCBidHcuKQoKT3RoZXIgdGhhbiB0aGF0LCBpdCBhbHNvIGxv b2tzIGdvb2QgdG8gbWUuCgpJJ2Qgc2F5LCBnbyBhaGVhZCEKCi0tIApQZWRy byBBbHZlcwo= >From gdb-patches-return-60152-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Nov 20 06:14:33 2008 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 15175 invoked by alias); 20 Nov 2008 06:14:32 -0000 Received: (qmail 15016 invoked by uid 22791); 20 Nov 2008 06:14:31 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Nov 2008 06:13:23 +0000 Received: from zps75.corp.google.com (zps75.corp.google.com [172.25.146.75]) by smtp-out.google.com with ESMTP id mAK6DL56010130 for ; Wed, 19 Nov 2008 22:13:21 -0800 Received: from rv-out-0506.google.com (rvbf9.prod.google.com [10.140.82.9]) by zps75.corp.google.com with ESMTP id mAK6DKB7010659 for ; Wed, 19 Nov 2008 22:13:20 -0800 Received: by rv-out-0506.google.com with SMTP id f9so773431rvb.7 for ; Wed, 19 Nov 2008 22:13:20 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.139.3 with SMTP id m3mr1053034rvd.140.1227161599944; Wed, 19 Nov 2008 22:13:19 -0800 (PST) In-Reply-To: <200811200554.46138.pedro@codesourcery.com> References: <20081119225237.1D8751C799D@localhost> <200811200554.46138.pedro@codesourcery.com> Date: Thu, 20 Nov 2008 14:43:00 -0000 Message-ID: Subject: Re: [RFA] fix thinko in sym info From: Doug Evans To: Pedro Alves Cc: gdb-patches@sourceware.org, ppluzhnikov@google.com Content-Type: multipart/mixed; boundary=000e0cd22b243f27d1045c18d3e5 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org X-SW-Source: 2008-11/txt/msg00543.txt.bz2 --000e0cd22b243f27d1045c18d3e5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 797 On Wed, Nov 19, 2008 at 9:54 PM, Pedro Alves wrote: > This should be: > >> + if (offset) >> + xasprintf (&loc_string, "%s + %u", msym_name, offset); >> + else >> + xasprintf (&loc_string, "%s", msym_name); >> + > > ... = make_cleanup (xfree, loc_string); > > >> + free (loc_string); > > do_cleanups (...); > >> } > > ... instead of raw 'free'. > > The easiest exception you can get here, is if the user quits on a > pagination request inside print_filtered. > > There, see, a huge leak is plugged fixed. :-) > > (would be s/free/xfree/, btw.) > > Other than that, it also looks good to me. > > I'd say, go ahead! Oh bother. Good catch. Can you (or someone) review this patch which includes the suggested changes? --000e0cd22b243f27d1045c18d3e5 Content-Type: text/plain; charset=US-ASCII; name="gdb-081119-sym-info-2.patch.txt" Content-Disposition: attachment; filename="gdb-081119-sym-info-2.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fnr0ay560 Content-length: 4889 MjAwOC0xMS0xOSAgRG91ZyBFdmFucyAgPGRqZUBnb29nbGUuY29tPgoKCSog cHJpbnRjbWQuYyAoc3ltX2luZm8pOiBEb24ndCBwcmludCB0aGUgb2Zmc2V0 IGlmIGl0J3MgemVyby4KCkluZGV4OiBwcmludGNtZC5jCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvcHJpbnRj bWQuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMzcKZGlmZiAtdSAtcCAt cjEuMTM3IHByaW50Y21kLmMKLS0tIHByaW50Y21kLmMJMTggTm92IDIwMDgg MjE6MzE6MjYgLTAwMDAJMS4xMzcKKysrIHByaW50Y21kLmMJMjAgTm92IDIw MDggMDY6MDk6MzAgLTAwMDAKQEAgLTEwMTMsNiArMTAxMyw4IEBAIHN5bV9p bmZvIChjaGFyICphcmcsIGludCBmcm9tX3R0eSkKIAkmJiAobXN5bWJvbCA9 IGxvb2t1cF9taW5pbWFsX3N5bWJvbF9ieV9wY19zZWN0aW9uIChzZWN0X2Fk ZHIsIG9zZWN0KSkpCiAgICAgICB7CiAJY29uc3QgY2hhciAqb2JqX25hbWUs ICptYXBwZWQsICpzZWNfbmFtZSwgKm1zeW1fbmFtZTsKKwljaGFyICpsb2Nf c3RyaW5nOworCXN0cnVjdCBjbGVhbnVwICpvbGRfY2hhaW47CiAKIAltYXRj aGVzID0gMTsKIAlvZmZzZXQgPSBzZWN0X2FkZHIgLSBTWU1CT0xfVkFMVUVf QUREUkVTUyAobXN5bWJvbCk7CkBAIC0xMDIwLDQzICsxMDIyLDU1IEBAIHN5 bV9pbmZvIChjaGFyICphcmcsIGludCBmcm9tX3R0eSkKIAlzZWNfbmFtZSA9 IG9zZWN0LT50aGVfYmZkX3NlY3Rpb24tPm5hbWU7CiAJbXN5bV9uYW1lID0g U1lNQk9MX1BSSU5UX05BTUUgKG1zeW1ib2wpOwogCisJLyogRG9uJ3QgcHJp bnQgdGhlIG9mZnNldCBpZiBpdCBpcyB6ZXJvLgorCSAgIFdlIGFzc3VtZSB0 aGVyZSdzIG5vIG5lZWQgdG8gaGFuZGxlIGkxOG4gb2YgInN5bSArIG9mZnNl dCIuICAqLworCWlmIChvZmZzZXQpCisJICB4YXNwcmludGYgKCZsb2Nfc3Ry aW5nLCAiJXMgKyAldSIsIG1zeW1fbmFtZSwgb2Zmc2V0KTsKKwllbHNlCisJ ICB4YXNwcmludGYgKCZsb2Nfc3RyaW5nLCAiJXMiLCBtc3ltX25hbWUpOwor CisJLyogVXNlIGEgY2xlYW51cCB0byBmcmVlIGxvY19zdHJpbmcgaW4gY2Fz ZSB0aGUgdXNlciBxdWl0cworCSAgIGEgcGFnaW5hdGlvbiByZXF1ZXN0IGlu c2lkZSBwcmludGZfZmlsdGVyZWQuICAqLworCW9sZF9jaGFpbiA9IG1ha2Vf Y2xlYW51cCAoeGZyZWUsIGxvY19zdHJpbmcpOworCiAJZ2RiX2Fzc2VydCAo b3NlY3QtPm9iamZpbGUgJiYgb3NlY3QtPm9iamZpbGUtPm5hbWUpOwogCW9i al9uYW1lID0gb3NlY3QtPm9iamZpbGUtPm5hbWU7CiAKIAlpZiAoTVVMVElf T0JKRklMRV9QICgpKQogCSAgaWYgKHBjX2luX3VubWFwcGVkX3JhbmdlIChh ZGRyLCBvc2VjdCkpCiAJICAgIGlmIChzZWN0aW9uX2lzX292ZXJsYXkgKG9z ZWN0KSkKLQkgICAgICBwcmludGZfZmlsdGVyZWQgKF8oIiVzICsgJXUgaW4g bG9hZCBhZGRyZXNzIHJhbmdlIG9mICIKKwkgICAgICBwcmludGZfZmlsdGVy ZWQgKF8oIiVzIGluIGxvYWQgYWRkcmVzcyByYW5nZSBvZiAiCiAJCQkJICIl cyBvdmVybGF5IHNlY3Rpb24gJXMgb2YgJXNcbiIpLAotCQkJICAgICAgIG1z eW1fbmFtZSwgb2Zmc2V0LAotCQkJICAgICAgIG1hcHBlZCwgc2VjX25hbWUs IG9ial9uYW1lKTsKKwkJCSAgICAgICBsb2Nfc3RyaW5nLCBtYXBwZWQsIHNl Y19uYW1lLCBvYmpfbmFtZSk7CiAJICAgIGVsc2UKLQkgICAgICBwcmludGZf ZmlsdGVyZWQgKF8oIiVzICsgJXUgaW4gbG9hZCBhZGRyZXNzIHJhbmdlIG9m ICIKKwkgICAgICBwcmludGZfZmlsdGVyZWQgKF8oIiVzIGluIGxvYWQgYWRk cmVzcyByYW5nZSBvZiAiCiAJCQkJICJzZWN0aW9uICVzIG9mICVzXG4iKSwK LQkJCSAgICAgICBtc3ltX25hbWUsIG9mZnNldCwgc2VjX25hbWUsIG9ial9u YW1lKTsKKwkJCSAgICAgICBsb2Nfc3RyaW5nLCBzZWNfbmFtZSwgb2JqX25h bWUpOwogCSAgZWxzZQogCSAgICBpZiAoc2VjdGlvbl9pc19vdmVybGF5IChv c2VjdCkpCi0JICAgICAgcHJpbnRmX2ZpbHRlcmVkIChfKCIlcyArICV1IGlu ICVzIG92ZXJsYXkgc2VjdGlvbiAlcyBvZiAlc1xuIiksCi0JCQkgICAgICAg bXN5bV9uYW1lLCBvZmZzZXQsIG1hcHBlZCwgc2VjX25hbWUsIG9ial9uYW1l KTsKKwkgICAgICBwcmludGZfZmlsdGVyZWQgKF8oIiVzIGluICVzIG92ZXJs YXkgc2VjdGlvbiAlcyBvZiAlc1xuIiksCisJCQkgICAgICAgbG9jX3N0cmlu ZywgbWFwcGVkLCBzZWNfbmFtZSwgb2JqX25hbWUpOwogCSAgICBlbHNlCi0J ICAgICAgcHJpbnRmX2ZpbHRlcmVkIChfKCIlcyArICV1IGluIHNlY3Rpb24g JXMgb2YgJXNcbiIpLAotCQkJICAgICAgIG1zeW1fbmFtZSwgb2Zmc2V0LCBz ZWNfbmFtZSwgb2JqX25hbWUpOworCSAgICAgIHByaW50Zl9maWx0ZXJlZCAo XygiJXMgaW4gc2VjdGlvbiAlcyBvZiAlc1xuIiksCisJCQkgICAgICAgbG9j X3N0cmluZywgc2VjX25hbWUsIG9ial9uYW1lKTsKIAllbHNlCiAJICBpZiAo cGNfaW5fdW5tYXBwZWRfcmFuZ2UgKGFkZHIsIG9zZWN0KSkKIAkgICAgaWYg KHNlY3Rpb25faXNfb3ZlcmxheSAob3NlY3QpKQotCSAgICAgIHByaW50Zl9m aWx0ZXJlZCAoXygiJXMgKyAldSBpbiBsb2FkIGFkZHJlc3MgcmFuZ2Ugb2Yg JXMgb3ZlcmxheSAiCisJICAgICAgcHJpbnRmX2ZpbHRlcmVkIChfKCIlcyBp biBsb2FkIGFkZHJlc3MgcmFuZ2Ugb2YgJXMgb3ZlcmxheSAiCiAJCQkJICJz ZWN0aW9uICVzXG4iKSwKLQkJCSAgICAgICBtc3ltX25hbWUsIG9mZnNldCwg bWFwcGVkLCBzZWNfbmFtZSk7CisJCQkgICAgICAgbG9jX3N0cmluZywgbWFw cGVkLCBzZWNfbmFtZSk7CiAJICAgIGVsc2UKLQkgICAgICBwcmludGZfZmls dGVyZWQgKF8oIiVzICsgJXUgaW4gbG9hZCBhZGRyZXNzIHJhbmdlIG9mIHNl Y3Rpb24gJXNcbiIpLAotCQkJICAgICAgIG1zeW1fbmFtZSwgb2Zmc2V0LCBz ZWNfbmFtZSk7CisJICAgICAgcHJpbnRmX2ZpbHRlcmVkIChfKCIlcyBpbiBs b2FkIGFkZHJlc3MgcmFuZ2Ugb2Ygc2VjdGlvbiAlc1xuIiksCisJCQkgICAg ICAgbG9jX3N0cmluZywgc2VjX25hbWUpOwogCSAgZWxzZQogCSAgICBpZiAo c2VjdGlvbl9pc19vdmVybGF5IChvc2VjdCkpCi0JICAgICAgcHJpbnRmX2Zp bHRlcmVkIChfKCIlcyArICV1IGluICVzIG92ZXJsYXkgc2VjdGlvbiAlc1xu IiksCi0JCQkgICAgICAgbXN5bV9uYW1lLCBvZmZzZXQsIG1hcHBlZCwgc2Vj X25hbWUpOworCSAgICAgIHByaW50Zl9maWx0ZXJlZCAoXygiJXMgaW4gJXMg b3ZlcmxheSBzZWN0aW9uICVzXG4iKSwKKwkJCSAgICAgICBsb2Nfc3RyaW5n LCBtYXBwZWQsIHNlY19uYW1lKTsKIAkgICAgZWxzZQotCSAgICAgIHByaW50 Zl9maWx0ZXJlZCAoXygiJXMgKyAldSBpbiBzZWN0aW9uICVzXG4iKSwKLQkJ CSAgICAgICBtc3ltX25hbWUsIG9mZnNldCwgc2VjX25hbWUpOworCSAgICAg IHByaW50Zl9maWx0ZXJlZCAoXygiJXMgaW4gc2VjdGlvbiAlc1xuIiksCisJ CQkgICAgICAgbG9jX3N0cmluZywgc2VjX25hbWUpOworCisJZG9fY2xlYW51 cHMgKG9sZF9jaGFpbik7CiAgICAgICB9CiAgIH0KICAgaWYgKG1hdGNoZXMg PT0gMCkK --000e0cd22b243f27d1045c18d3e5--