Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: ppluzhnikov@google.com, gdb-patches@sourceware.org
Subject: Re: [RFA] fix thinko in sym info
Date: Thu, 20 Nov 2008 02:10:00 -0000	[thread overview]
Message-ID: <20081119233115.GD3838@adacore.com> (raw)
In-Reply-To: <20081119225237.1D8751C799D@localhost>

> The outstanding question is, of course, whether
> 
>   "%s + %u", msym_name, offset
> 
> needs i18n.  This patch assumes it doesn't.

I would tend to agree, although perhaps someone who has knowledge with
languages that write right-to-left might come up with a case where
they'd translate "SYMBOL + OFFSET" differently from the original.
In other words, I'm hoping that "SYMBOL + OFFSET" is international.

Also, I would think that the "SYMBOL + OFFSET" part is one entity
that would not be split during translation to any language. This is
derived from the assumption above.

> 2008-11-19  Doug Evans  <dje@google.com>
> 
> 	* printcmd.c (sym_info): Don't print the offset if it's zero.

In my opinion, that's fine. We can always fix the problem later if
someone comes up with a situation where the current approach is
too limited - that'd be pretty easy to do.

Any objection to this patch being applied?

-- 
Joel


  parent reply	other threads:[~2008-11-19 23:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-20  2:03 Doug Evans
2008-11-20  2:06 ` Paul Pluzhnikov
2008-11-20  2:08   ` Doug Evans
2008-11-20  2:10 ` Joel Brobecker [this message]
2008-11-20  8:46   ` Eli Zaretskii
2008-11-20 14:33 ` Pedro Alves
     [not found]   ` <e394668d0811192213u7c5edd9fr2e243d8699b0a632@mail.gmail.com>
2008-11-21  1:42     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081119233115.GD3838@adacore.com \
    --to=brobecker@adacore.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ppluzhnikov@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox