From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31515 invoked by alias); 19 Nov 2008 23:32:09 -0000 Received: (qmail 31385 invoked by uid 22791); 19 Nov 2008 23:31:58 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Nov 2008 23:31:23 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2B5072A9683; Wed, 19 Nov 2008 18:31:21 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id XL5HFPoEKOvG; Wed, 19 Nov 2008 18:31:21 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 137502A9681; Wed, 19 Nov 2008 18:31:21 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C9C0BE7ACD; Wed, 19 Nov 2008 18:31:15 -0500 (EST) Date: Thu, 20 Nov 2008 02:10:00 -0000 From: Joel Brobecker To: Doug Evans Cc: ppluzhnikov@google.com, gdb-patches@sourceware.org Subject: Re: [RFA] fix thinko in sym info Message-ID: <20081119233115.GD3838@adacore.com> References: <20081119225237.1D8751C799D@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081119225237.1D8751C799D@localhost> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00517.txt.bz2 > The outstanding question is, of course, whether > > "%s + %u", msym_name, offset > > needs i18n. This patch assumes it doesn't. I would tend to agree, although perhaps someone who has knowledge with languages that write right-to-left might come up with a case where they'd translate "SYMBOL + OFFSET" differently from the original. In other words, I'm hoping that "SYMBOL + OFFSET" is international. Also, I would think that the "SYMBOL + OFFSET" part is one entity that would not be split during translation to any language. This is derived from the assumption above. > 2008-11-19 Doug Evans > > * printcmd.c (sym_info): Don't print the offset if it's zero. In my opinion, that's fine. We can always fix the problem later if someone comes up with a situation where the current approach is too limited - that'd be pretty easy to do. Any objection to this patch being applied? -- Joel