From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11331 invoked by alias); 19 Nov 2008 23:03:40 -0000 Received: (qmail 11115 invoked by uid 22791); 19 Nov 2008 23:03:39 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Nov 2008 23:02:47 +0000 Received: from spaceape23.eur.corp.google.com (spaceape23.eur.corp.google.com [172.28.16.75]) by smtp-out.google.com with ESMTP id mAJN2iPG008626 for ; Wed, 19 Nov 2008 15:02:45 -0800 Received: from wf-out-1314.google.com (wfa28.prod.google.com [10.142.1.28]) by spaceape23.eur.corp.google.com with ESMTP id mAJN2gkj011048 for ; Wed, 19 Nov 2008 15:02:43 -0800 Received: by wf-out-1314.google.com with SMTP id 28so165052wfa.27 for ; Wed, 19 Nov 2008 15:02:41 -0800 (PST) MIME-Version: 1.0 Received: by 10.114.81.1 with SMTP id e1mr927557wab.212.1227135761966; Wed, 19 Nov 2008 15:02:41 -0800 (PST) In-Reply-To: <20081119225237.1D8751C799D@localhost> References: <20081119225237.1D8751C799D@localhost> Date: Thu, 20 Nov 2008 02:06:00 -0000 Message-ID: <8ac60eac0811191502r637cc72en87554285734a5911@mail.gmail.com> Subject: Re: [RFA] fix thinko in sym info From: Paul Pluzhnikov To: Doug Evans Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00515.txt.bz2 On Wed, Nov 19, 2008 at 2:52 PM, Doug Evans wrote: > asm-source.exp is now failing because it doesn't expect the offset > to be printed if its zero. > One could update the testcase, but the old behaviour is more user-friendly. Hmm, why didn't I notice this failure ... It's UNTESTED for me both before and after. I'll investigate why. > The outstanding question is, of course, whether > "%s + %u", msym_name, offset > needs i18n. This patch assumes it doesn't. From: http://sourceware.org/ml/gdb-patches/2008-11/msg00378.html In addition, translating each part without seeing the whole sentence is very difficult. I didn't want to add 8 more clauses to this if statement. Regards, -- Paul Pluzhnikov