From: Luis Machado <lgustavo@codesourcery.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH, obvious?] Fix incorrect reference to source files
Date: Tue, 06 Dec 2016 23:07:00 -0000 [thread overview]
Message-ID: <89c025d1-0966-c6d4-42cf-0773e7eddd98@codesourcery.com> (raw)
In-Reply-To: <cacf1eb43a77de4b784fe1d283fdc42d@polymtl.ca>
On 12/06/2016 05:02 PM, Simon Marchi wrote:
> On 2016-12-06 17:55, Luis Machado wrote:
>> How about the following? I also fixed another occurrences of the same
>> mistake
>> in another source file.
>>
>> ----
>>
>> gdb/gdbserver/ChangeLog:
>>
>> 2016-12-06 Luis Machado <lgustavo@codesourcery.com>
>>
>> * win32-i386-low.c: Fix incorrect reference to a couple source files.
>> * nto-x86-low.c: Likewise.
>> ---
>> gdb/gdbserver/nto-x86-low.c | 2 +-
>> gdb/gdbserver/win32-i386-low.c | 4 ++--
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/gdb/gdbserver/nto-x86-low.c b/gdb/gdbserver/nto-x86-low.c
>> index da77c54..c7303ab 100644
>> --- a/gdb/gdbserver/nto-x86-low.c
>> +++ b/gdb/gdbserver/nto-x86-low.c
>> @@ -25,7 +25,7 @@
>> #include <x86/context.h>
>>
>>
>> -/* Definition auto generated from reg-i386.dep. */
>> +/* Defined in auto-generated build-time file gdb/gdbserver/i386.c. */
>> extern void init_registers_i386 ();
>> extern struct reg *regs_i386;
>> extern const struct target_desc *tdesc_i386;
>> diff --git a/gdb/gdbserver/win32-i386-low.c
>> b/gdb/gdbserver/win32-i386-low.c
>> index 5daa863..dc20d68 100644
>> --- a/gdb/gdbserver/win32-i386-low.c
>> +++ b/gdb/gdbserver/win32-i386-low.c
>> @@ -29,11 +29,11 @@
>> #define FLAG_TRACE_BIT 0x100
>>
>> #ifdef __x86_64__
>> -/* Defined in auto-generated file reg-amd64.c. */
>> +/* Defined in auto-generated build-time file gdb/gdbserver/amd64.c. */
>> void init_registers_amd64 (void);
>> extern const struct target_desc *tdesc_amd64;
>> #else
>> -/* Defined in auto-generated file reg-i386.c. */
>> +/* Defined in auto-generated build-time file gdb/gdbserver/i386.c. */
>> void init_registers_i386 (void);
>> extern const struct target_desc *tdesc_i386;
>> #endif
>
> You used the wrong directory :).
>
> gdb/gdbserver -> gdb/features/i386
>
The files don't live inside gdb/features/, they are auto-generated based
on the .dat files from gdb/regformats/ and put inside
<build>/gdb/gdbserver/, no?
next prev parent reply other threads:[~2016-12-06 23:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 16:15 Luis Machado
2016-12-06 18:54 ` Simon Marchi
2016-12-06 19:08 ` Luis Machado
2016-12-06 22:56 ` Luis Machado
2016-12-06 23:02 ` Simon Marchi
2016-12-06 23:07 ` Luis Machado [this message]
2016-12-06 23:15 ` Simon Marchi
2016-12-07 18:58 ` Luis Machado
2016-12-09 17:02 ` Pedro Alves
2016-12-23 16:58 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89c025d1-0966-c6d4-42cf-0773e7eddd98@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox