From: Luis Machado <lgustavo@codesourcery.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH, obvious?] Fix incorrect reference to source files
Date: Wed, 07 Dec 2016 18:58:00 -0000 [thread overview]
Message-ID: <12052764-8cc7-b583-64b7-da5488865e2e@codesourcery.com> (raw)
In-Reply-To: <1ae9c5832a714650a4fd190ce081b1c7@polymtl.ca>
On 12/06/2016 05:14 PM, Simon Marchi wrote:
> On 2016-12-06 18:06, Luis Machado wrote:
>> The files don't live inside gdb/features/, they are auto-generated
>> based on the .dat files from gdb/regformats/ and put inside
>> <build>/gdb/gdbserver/, no?
>
> Oh ok I got confused with the other files named the same way, sorry.
> Then if they're all in the same directory, my initial comment may not
> apply, it might be obvious enough.
I'm still happy with the last patch. I think it clarifies things a bit
or at least points the user toward the right direction (build directory).
Does anyone have objections?
next prev parent reply other threads:[~2016-12-07 18:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 16:15 Luis Machado
2016-12-06 18:54 ` Simon Marchi
2016-12-06 19:08 ` Luis Machado
2016-12-06 22:56 ` Luis Machado
2016-12-06 23:02 ` Simon Marchi
2016-12-06 23:07 ` Luis Machado
2016-12-06 23:15 ` Simon Marchi
2016-12-07 18:58 ` Luis Machado [this message]
2016-12-09 17:02 ` Pedro Alves
2016-12-23 16:58 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12052764-8cc7-b583-64b7-da5488865e2e@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox