Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Luis Machado <lgustavo@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH, obvious?] Fix incorrect reference to source files
Date: Tue, 06 Dec 2016 18:54:00 -0000	[thread overview]
Message-ID: <2c0de800bcae514b2a8c27c6f47271da@polymtl.ca> (raw)
In-Reply-To: <1481040941-21237-1-git-send-email-lgustavo@codesourcery.com>

On 2016-12-06 11:15, Luis Machado wrote:
> These auto-generated register source files have been renamed back in 
> 2010.
> 
> It took me a while to find these due to the mismatch.
> 
> gdb/gdbserver/ChangeLog:
> 
> 2016-12-06  Luis Machado  <lgustavo@codesourcery.com>
> 
> 	* win32-i386-low.c: Fix incorrect reference to a couple source files.
> ---
>  gdb/gdbserver/win32-i386-low.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/gdbserver/win32-i386-low.c 
> b/gdb/gdbserver/win32-i386-low.c
> index 5daa863..edae9bb 100644
> --- a/gdb/gdbserver/win32-i386-low.c
> +++ b/gdb/gdbserver/win32-i386-low.c
> @@ -29,11 +29,11 @@
>  #define FLAG_TRACE_BIT 0x100
> 
>  #ifdef __x86_64__
> -/* Defined in auto-generated file reg-amd64.c.  */
> +/* Defined in auto-generated file amd64.c.  */
>  void init_registers_amd64 (void);
>  extern const struct target_desc *tdesc_amd64;
>  #else
> -/* Defined in auto-generated file reg-i386.c.  */
> +/* Defined in auto-generated file i386.c.  */
>  void init_registers_i386 (void);
>  extern const struct target_desc *tdesc_i386;
>  #endif

You could also put the full path to the file, either 
features/i386/amd64.c or gdb/features/i386/amd64.c, since it's not 
obvious where those files are located (although a "find" finds it 
quickly).


  reply	other threads:[~2016-12-06 18:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-06 16:15 Luis Machado
2016-12-06 18:54 ` Simon Marchi [this message]
2016-12-06 19:08   ` Luis Machado
2016-12-06 22:56   ` Luis Machado
2016-12-06 23:02     ` Simon Marchi
2016-12-06 23:07       ` Luis Machado
2016-12-06 23:15         ` Simon Marchi
2016-12-07 18:58           ` Luis Machado
2016-12-09 17:02             ` Pedro Alves
2016-12-23 16:58               ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c0de800bcae514b2a8c27c6f47271da@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox