From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26981 invoked by alias); 6 Dec 2016 18:54:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26968 invoked by uid 89); 6 Dec 2016 18:54:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL,URIBL_RED autolearn=no version=3.3.2 spammy=Hx-languages-length:1348, H*i:sk:1481040, H*f:sk:1481040 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Dec 2016 18:54:13 +0000 Received: by simark.ca (Postfix, from userid 33) id 765A31E18B; Tue, 6 Dec 2016 13:54:11 -0500 (EST) To: Luis Machado Subject: Re: [PATCH, obvious?] Fix incorrect reference to source files X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 06 Dec 2016 18:54:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <1481040941-21237-1-git-send-email-lgustavo@codesourcery.com> References: <1481040941-21237-1-git-send-email-lgustavo@codesourcery.com> Message-ID: <2c0de800bcae514b2a8c27c6f47271da@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.3 X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00173.txt.bz2 On 2016-12-06 11:15, Luis Machado wrote: > These auto-generated register source files have been renamed back in > 2010. > > It took me a while to find these due to the mismatch. > > gdb/gdbserver/ChangeLog: > > 2016-12-06 Luis Machado > > * win32-i386-low.c: Fix incorrect reference to a couple source files. > --- > gdb/gdbserver/win32-i386-low.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/gdbserver/win32-i386-low.c > b/gdb/gdbserver/win32-i386-low.c > index 5daa863..edae9bb 100644 > --- a/gdb/gdbserver/win32-i386-low.c > +++ b/gdb/gdbserver/win32-i386-low.c > @@ -29,11 +29,11 @@ > #define FLAG_TRACE_BIT 0x100 > > #ifdef __x86_64__ > -/* Defined in auto-generated file reg-amd64.c. */ > +/* Defined in auto-generated file amd64.c. */ > void init_registers_amd64 (void); > extern const struct target_desc *tdesc_amd64; > #else > -/* Defined in auto-generated file reg-i386.c. */ > +/* Defined in auto-generated file i386.c. */ > void init_registers_i386 (void); > extern const struct target_desc *tdesc_i386; > #endif You could also put the full path to the file, either features/i386/amd64.c or gdb/features/i386/amd64.c, since it's not obvious where those files are located (although a "find" finds it quickly).