From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37564 invoked by alias); 6 Dec 2016 23:07:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37550 invoked by uid 89); 6 Dec 2016 23:07:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:2049, H*MI:sk:cacf1eb, H*i:sk:cacf1eb, H*f:sk:cacf1eb X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Dec 2016 23:06:53 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cEOp2-0005mq-2Z from Luis_Gustavo@mentor.com ; Tue, 06 Dec 2016 15:06:52 -0800 Received: from [172.30.7.171] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 6 Dec 2016 15:06:49 -0800 Reply-To: Luis Machado Subject: Re: [PATCH, obvious?] Fix incorrect reference to source files References: <2c0de800bcae514b2a8c27c6f47271da@polymtl.ca> <1481064953-31780-1-git-send-email-lgustavo@codesourcery.com> To: Simon Marchi CC: From: Luis Machado Message-ID: <89c025d1-0966-c6d4-42cf-0773e7eddd98@codesourcery.com> Date: Tue, 06 Dec 2016 23:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00185.txt.bz2 On 12/06/2016 05:02 PM, Simon Marchi wrote: > On 2016-12-06 17:55, Luis Machado wrote: >> How about the following? I also fixed another occurrences of the same >> mistake >> in another source file. >> >> ---- >> >> gdb/gdbserver/ChangeLog: >> >> 2016-12-06 Luis Machado >> >> * win32-i386-low.c: Fix incorrect reference to a couple source files. >> * nto-x86-low.c: Likewise. >> --- >> gdb/gdbserver/nto-x86-low.c | 2 +- >> gdb/gdbserver/win32-i386-low.c | 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/gdb/gdbserver/nto-x86-low.c b/gdb/gdbserver/nto-x86-low.c >> index da77c54..c7303ab 100644 >> --- a/gdb/gdbserver/nto-x86-low.c >> +++ b/gdb/gdbserver/nto-x86-low.c >> @@ -25,7 +25,7 @@ >> #include >> >> >> -/* Definition auto generated from reg-i386.dep. */ >> +/* Defined in auto-generated build-time file gdb/gdbserver/i386.c. */ >> extern void init_registers_i386 (); >> extern struct reg *regs_i386; >> extern const struct target_desc *tdesc_i386; >> diff --git a/gdb/gdbserver/win32-i386-low.c >> b/gdb/gdbserver/win32-i386-low.c >> index 5daa863..dc20d68 100644 >> --- a/gdb/gdbserver/win32-i386-low.c >> +++ b/gdb/gdbserver/win32-i386-low.c >> @@ -29,11 +29,11 @@ >> #define FLAG_TRACE_BIT 0x100 >> >> #ifdef __x86_64__ >> -/* Defined in auto-generated file reg-amd64.c. */ >> +/* Defined in auto-generated build-time file gdb/gdbserver/amd64.c. */ >> void init_registers_amd64 (void); >> extern const struct target_desc *tdesc_amd64; >> #else >> -/* Defined in auto-generated file reg-i386.c. */ >> +/* Defined in auto-generated build-time file gdb/gdbserver/i386.c. */ >> void init_registers_i386 (void); >> extern const struct target_desc *tdesc_i386; >> #endif > > You used the wrong directory :). > > gdb/gdbserver -> gdb/features/i386 > The files don't live inside gdb/features/, they are auto-generated based on the .dat files from gdb/regformats/ and put inside /gdb/gdbserver/, no?