Re: [3/3] RFC - optional patch to restore DW_AT_data_member_location

[Tom Tromey <tromey@redhat.com>]

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

>> +/* A helper for read_common_block that creates a locexpr baton.  */

Jan> I believe still the parameters should be documented in this case.

I did this.

Jan> I think this code is complicted enough to be worth an assertion:
Jan>      *ptr++ = DW_OP_plus;
Jan>      gdb_assert (ptr - baton->data == baton->size);

This too.

>> +	.string	"GNU Fortran 4.6.3 20120306 (Red Hat 4.6.3-2) -mtune=generic -march=x86-64 -g -fintrinsic-modules-path /usr/lib/gcc/x86_64-redhat-linux/4.6.3/finclude"

Jan> Probably not needing to be rebuilt but I think for FSF GDB it would
Jan> be better to precompile such .S files using FSF GCC, which could be
Jan> possibly (more easily) reproduced in the future.

I had to edit the .S file.  I would not want to try to reproduce this.
I guess if I was going to do it again I would try to use my DWARF
assembler instead.

I changed the string to

"GNU Fortran 4.6.3 plus hand hackery"

... which is reasonably true.

>> +.LASF15:
>> +	.string	"/home/tromey/gnu/archer/archer/gdb/testsuite/gdb.dwarf2"

Jan> While with:
Jan> -       .string "/home/tromey/gnu/archer/archer/gdb/testsuite/gdb.dwarf2"
Jan> +       .string "gdb.dwarf2"

Jan> it would work:
Jan> (gdb) l
Jan> 48     REAL*8               iz
Jan> [...]

This didn't work for me, I guess since I build out-of-tree.  I guess it
would work with a "dir" command.  I made the change anyhow.

Tom