From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2746 invoked by alias); 11 Sep 2012 20:56:41 -0000 Received: (qmail 2738 invoked by uid 22791); 11 Sep 2012 20:56:40 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Sep 2012 20:56:13 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8BKuCb1005721 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 11 Sep 2012 16:56:12 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q8BKuB6W006828 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 11 Sep 2012 16:56:11 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [3/3] RFC - optional patch to restore DW_AT_data_member_location References: <87628cfbg2.fsf@fleche.redhat.com> <20120826081205.GB29056@host2.jankratochvil.net> Date: Tue, 11 Sep 2012 20:56:00 -0000 In-Reply-To: <20120826081205.GB29056@host2.jankratochvil.net> (Jan Kratochvil's message of "Sun, 26 Aug 2012 10:12:05 +0200") Message-ID: <87zk4w6zys.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00182.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: >> +/* A helper for read_common_block that creates a locexpr baton. */ Jan> I believe still the parameters should be documented in this case. I did this. Jan> I think this code is complicted enough to be worth an assertion: Jan> *ptr++ = DW_OP_plus; Jan> gdb_assert (ptr - baton->data == baton->size); This too. >> + .string "GNU Fortran 4.6.3 20120306 (Red Hat 4.6.3-2) -mtune=generic -march=x86-64 -g -fintrinsic-modules-path /usr/lib/gcc/x86_64-redhat-linux/4.6.3/finclude" Jan> Probably not needing to be rebuilt but I think for FSF GDB it would Jan> be better to precompile such .S files using FSF GCC, which could be Jan> possibly (more easily) reproduced in the future. I had to edit the .S file. I would not want to try to reproduce this. I guess if I was going to do it again I would try to use my DWARF assembler instead. I changed the string to "GNU Fortran 4.6.3 plus hand hackery" ... which is reasonably true. >> +.LASF15: >> + .string "/home/tromey/gnu/archer/archer/gdb/testsuite/gdb.dwarf2" Jan> While with: Jan> - .string "/home/tromey/gnu/archer/archer/gdb/testsuite/gdb.dwarf2" Jan> + .string "gdb.dwarf2" Jan> it would work: Jan> (gdb) l Jan> 48 REAL*8 iz Jan> [...] This didn't work for me, I guess since I build out-of-tree. I guess it would work with a "dir" command. I made the change anyhow. Tom