From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [3/3] RFC - optional patch to restore DW_AT_data_member_location
Date: Wed, 12 Sep 2012 13:25:00 -0000 [thread overview]
Message-ID: <20120912132520.GA2130@host2.jankratochvil.net> (raw)
In-Reply-To: <87zk4w6zys.fsf@fleche.redhat.com>
On Tue, 11 Sep 2012 22:56:11 +0200, Tom Tromey wrote:
> >> + .string "GNU Fortran 4.6.3 20120306 (Red Hat 4.6.3-2) -mtune=generic -march=x86-64 -g -fintrinsic-modules-path /usr/lib/gcc/x86_64-redhat-linux/4.6.3/finclude"
>
> Jan> Probably not needing to be rebuilt but I think for FSF GDB it would
> Jan> be better to precompile such .S files using FSF GCC, which could be
> Jan> possibly (more easily) reproduced in the future.
>
> I had to edit the .S file. I would not want to try to reproduce this.
> I guess if I was going to do it again I would try to use my DWARF
> assembler instead.
>
> I changed the string to
>
> "GNU Fortran 4.6.3 plus hand hackery"
>
> ... which is reasonably true.
I see I did not make clear why I like the reproducibility of the compilation.
This is because sometimes it is good to know what was hand-edited in the file
and I find a bit excessive to keep both the original and the hand-edited .S
files in the repository due to it. This is why I sometimes
did #if 0-#else-#endif or #if 0-#endif-#if 1-#endif constructs in the .S
files (I see it now only in gdb.dwarf2/dw2-const.S).
I sure do not insist on anything like that, just FYI.
Thanks,
Jan
next prev parent reply other threads:[~2012-09-12 13:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 18:22 Tom Tromey
2012-08-21 22:12 ` Doug Evans
2012-08-24 16:53 ` Jan Kratochvil
2012-09-02 15:04 ` Joel Brobecker
2012-09-11 20:42 ` Tom Tromey
2012-08-26 8:12 ` Jan Kratochvil
2012-09-11 20:56 ` Tom Tromey
2012-09-12 13:25 ` Jan Kratochvil [this message]
2012-09-12 14:26 ` Tom Tromey
2012-09-12 14:36 ` Tom Tromey
2012-09-12 14:39 ` Tom Tromey
2012-09-26 19:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912132520.GA2130@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox