From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9261 invoked by alias); 12 Sep 2012 13:25:39 -0000 Received: (qmail 9247 invoked by uid 22791); 12 Sep 2012 13:25:38 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Sep 2012 13:25:25 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8CDPPI7023925 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Sep 2012 09:25:25 -0400 Received: from host2.jankratochvil.net (ovpn-116-25.ams2.redhat.com [10.36.116.25]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q8CDPKR1020136 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 12 Sep 2012 09:25:23 -0400 Date: Wed, 12 Sep 2012 13:25:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [3/3] RFC - optional patch to restore DW_AT_data_member_location Message-ID: <20120912132520.GA2130@host2.jankratochvil.net> References: <87628cfbg2.fsf@fleche.redhat.com> <20120826081205.GB29056@host2.jankratochvil.net> <87zk4w6zys.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zk4w6zys.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00195.txt.bz2 On Tue, 11 Sep 2012 22:56:11 +0200, Tom Tromey wrote: > >> + .string "GNU Fortran 4.6.3 20120306 (Red Hat 4.6.3-2) -mtune=generic -march=x86-64 -g -fintrinsic-modules-path /usr/lib/gcc/x86_64-redhat-linux/4.6.3/finclude" > > Jan> Probably not needing to be rebuilt but I think for FSF GDB it would > Jan> be better to precompile such .S files using FSF GCC, which could be > Jan> possibly (more easily) reproduced in the future. > > I had to edit the .S file. I would not want to try to reproduce this. > I guess if I was going to do it again I would try to use my DWARF > assembler instead. > > I changed the string to > > "GNU Fortran 4.6.3 plus hand hackery" > > ... which is reasonably true. I see I did not make clear why I like the reproducibility of the compilation. This is because sometimes it is good to know what was hand-edited in the file and I find a bit excessive to keep both the original and the hand-edited .S files in the repository due to it. This is why I sometimes did #if 0-#else-#endif or #if 0-#endif-#if 1-#endif constructs in the .S files (I see it now only in gdb.dwarf2/dw2-const.S). I sure do not insist on anything like that, just FYI. Thanks, Jan