From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] new memory-changed MI notification.
Date: Mon, 15 Oct 2012 19:03:00 -0000 [thread overview]
Message-ID: <87y5j7a78j.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5073D5B5.2060208@codesourcery.com> (Yao Qi's message of "Tue, 9 Oct 2012 15:43:49 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Tom> Usually I think it would be preferable to have a flag correspond to a
Tom> notification and not a command; but this would not work so well if a
Tom> command needed to suppress two different messages. (Though if that
Tom> happens then maybe we should have a slightly different approach based on
Tom> bitmasks.)
Yao> I agree with you that one flag should correspond to a notification. I
Yao> revised my patch a little bit to get rid of suppression flag
Yao> 'var_assign'.
Funny -- your previous message got me to agree that the bitmask approach
is overkill :)
Yao> 2012-10-09 Yao Qi <yao@codesourcery.com>
Yao> * breakpoint.c (invalidate_bp_value_on_memory_change): Add one
Yao> more parameter 'inferior'.
Yao> * corefile.c (write_memory_with_notification): Caller update.
Yao> * mi/mi-cmd-var.c: Include "mi-main.h".
Yao> (mi_cmd_var_assign): Set mi_suppress_notification.data_write_memory
Yao> to 1 and restore it later.
Yao> * mi/mi-cmds.c (mi_cmd mi_cmds): Update for "data-write-memory"
Yao> and "data-write-memory-bytes.
Yao> * mi/mi-interp.c: Include objfiles.h.
Yao> (mi_interpreter_init): Call observer_attach_memory_changed.
Yao> (mi_memory_changed): New.
Yao> * mi/mi-main.h (struct mi_suppress_notification) <memory>:
Yao> New field.
Either version of the patch is ok. Check in whichever one you prefer.
Tom
prev parent reply other threads:[~2012-10-15 19:03 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 0:49 [RFC 0/2] Two new MI notifications Yao Qi
2012-09-28 0:49 ` [PATCH 2/2] new tracepoint downloaded MI notification Yao Qi
2012-09-28 7:37 ` Eli Zaretskii
2012-09-28 17:44 ` Pedro Alves
2012-09-28 17:44 ` Pedro Alves
2012-09-28 17:47 ` Pedro Alves
2012-09-29 14:13 ` Yao Qi
2012-10-09 8:12 ` Yao Qi
2012-10-31 17:59 ` Pedro Alves
2012-10-31 19:20 ` Doug Evans
2012-11-01 0:34 ` Yao Qi
2012-11-02 15:46 ` Pedro Alves
2012-11-02 15:50 ` Pedro Alves
2012-10-18 1:16 ` Yao Qi
2012-10-18 1:28 ` Yao Qi
2012-10-30 7:07 ` [ping]: " Yao Qi
2012-10-30 17:22 ` Eli Zaretskii
2012-10-18 4:43 ` Eli Zaretskii
2012-10-18 19:54 ` Tom Tromey
2012-09-28 18:27 ` Tom Tromey
2012-09-28 18:29 ` Tom Tromey
2012-10-15 18:03 ` dje
2012-10-31 18:03 ` Pedro Alves
2012-10-31 19:10 ` Marc Khouzam
2012-11-01 0:22 ` Yao Qi
2012-11-22 18:33 ` Pedro Alves
2012-11-29 15:47 ` Yao Qi
2012-11-29 16:00 ` Pedro Alves
2012-11-29 19:34 ` Marc Khouzam
2012-09-28 0:49 ` [PATCH 1/2] new memory-changed " Yao Qi
2012-09-28 7:36 ` Eli Zaretskii
2012-09-28 7:58 ` Yao Qi
2012-09-28 8:25 ` Eli Zaretskii
2012-09-28 17:17 ` Tom Tromey
2012-09-29 1:18 ` Yao Qi
2012-10-09 7:44 ` Yao Qi
2012-10-15 17:58 ` dje
2012-10-15 19:07 ` Tom Tromey
2012-10-16 7:12 ` Yao Qi
2012-10-15 19:03 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5j7a78j.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox