Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: dje@google.com
Cc: Yao Qi <yao@codesourcery.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] new memory-changed MI notification.
Date: Mon, 15 Oct 2012 19:07:00 -0000	[thread overview]
Message-ID: <87txtva716.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20604.20161.315324.841784@ruffy2.mtv.corp.google.com>	(dje@google.com's message of "Mon, 15 Oct 2012 10:58:25 -0700")

>>>>> "Doug" == Douglas Evans <dje@google.com> writes:

Doug> For my own education, is this suppression just an optimization, or is
Doug> there a correctness issue here?
Doug> I can imagine that it's an optimization, why notify the frontend
Doug> something changed when it's the frontend that requested the change.
Doug> But there is *zero* documentation in mi-main.h on *why* struct
Doug> mi_suppress_notification exists, so it's hard to tell. :-(
Doug> [I realize your patch is just adding an entry, but I'd like to learn
Doug> what the reason for it is.]

I don't know about this case in particular, but in many cases in MI, a
command will have a result record that encodes the exact same data that
an async response would give.  On the other hand, if a CLI command is
invoked, then there is no relevant response record, and so the async
response must be generated.

I think it is an optimization.  Offhand I can't think of a correctness
issue here, but I guess I wouldn't be surprised if there is one lurking
for some command or another.

Tom


  reply	other threads:[~2012-10-15 19:07 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-28  0:49 [RFC 0/2] Two new MI notifications Yao Qi
2012-09-28  0:49 ` [PATCH 1/2] new memory-changed MI notification Yao Qi
2012-09-28  7:36   ` Eli Zaretskii
2012-09-28  7:58     ` Yao Qi
2012-09-28  8:25       ` Eli Zaretskii
2012-09-28 17:17   ` Tom Tromey
2012-09-29  1:18     ` Yao Qi
2012-10-09  7:44     ` Yao Qi
2012-10-15 17:58       ` dje
2012-10-15 19:07         ` Tom Tromey [this message]
2012-10-16  7:12         ` Yao Qi
2012-10-15 19:03       ` Tom Tromey
2012-09-28  0:49 ` [PATCH 2/2] new tracepoint downloaded " Yao Qi
2012-09-28  7:37   ` Eli Zaretskii
2012-09-28 17:44   ` Pedro Alves
2012-09-28 17:44   ` Pedro Alves
2012-09-28 17:47     ` Pedro Alves
2012-09-29 14:13       ` Yao Qi
2012-10-09  8:12         ` Yao Qi
2012-10-31 17:59         ` Pedro Alves
2012-10-31 19:20           ` Doug Evans
2012-11-01  0:34           ` Yao Qi
2012-11-02 15:46             ` Pedro Alves
2012-11-02 15:50               ` Pedro Alves
2012-10-18  1:16     ` Yao Qi
2012-10-18  1:28       ` Yao Qi
2012-10-30  7:07         ` [ping]: " Yao Qi
2012-10-30 17:22           ` Eli Zaretskii
2012-10-18  4:43       ` Eli Zaretskii
2012-10-18 19:54       ` Tom Tromey
2012-09-28 18:27   ` Tom Tromey
2012-09-28 18:29     ` Tom Tromey
2012-10-15 18:03   ` dje
2012-10-31 18:03     ` Pedro Alves
2012-10-31 19:10       ` Marc Khouzam
2012-11-01  0:22         ` Yao Qi
2012-11-22 18:33           ` Pedro Alves
2012-11-29 15:47             ` Yao Qi
2012-11-29 16:00               ` Pedro Alves
2012-11-29 19:34                 ` Marc Khouzam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txtva716.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox