Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] new tracepoint downloaded MI notification.
Date: Fri, 28 Sep 2012 17:44:00 -0000	[thread overview]
Message-ID: <5065E1E9.5040204@redhat.com> (raw)
In-Reply-To: <1348793347-12556-3-git-send-email-yao@codesourcery.com>

On 09/28/2012 01:49 AM, Yao Qi wrote:
> +@item =tracepoint-downloaded,id="@var{number}",address="@var{addr}"
> +Reports that a tracepoint was downloaded to target.  The @var{number}
> +is the ordinal number of the tracepoint.  The @var{addr} is the
> +address where tracepoint was downloaded.

The "address where tracepoint was downloaded" makes me think this
returns the address in gdbserver's memory that holds the tracepoint
object.  But it's not, it's the tracepoint's address, as in the
address the tracepoint is set at in the inferior.

Took me a second to recall, but the reason the address is
necessary is multi-location tracepoints -- a tracepoint on the
target is identified by the { number, address } tuple.  We don't
send over the location's sub number (like 1.1, 1.2, etc.).

Should we mention this somewhere (other than at the tracepoint
packets description), so frontend people don't wonder whether they
can ignore the address field, and why aren't the other fields of
the tracepoint (like spec string) included?

-- 
Pedro Alves


  parent reply	other threads:[~2012-09-28 17:44 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-28  0:49 [RFC 0/2] Two new MI notifications Yao Qi
2012-09-28  0:49 ` [PATCH 1/2] new memory-changed MI notification Yao Qi
2012-09-28  7:36   ` Eli Zaretskii
2012-09-28  7:58     ` Yao Qi
2012-09-28  8:25       ` Eli Zaretskii
2012-09-28 17:17   ` Tom Tromey
2012-09-29  1:18     ` Yao Qi
2012-10-09  7:44     ` Yao Qi
2012-10-15 17:58       ` dje
2012-10-15 19:07         ` Tom Tromey
2012-10-16  7:12         ` Yao Qi
2012-10-15 19:03       ` Tom Tromey
2012-09-28  0:49 ` [PATCH 2/2] new tracepoint downloaded " Yao Qi
2012-09-28  7:37   ` Eli Zaretskii
2012-09-28 17:44   ` Pedro Alves
2012-09-28 17:44   ` Pedro Alves [this message]
2012-09-28 17:47     ` Pedro Alves
2012-09-29 14:13       ` Yao Qi
2012-10-09  8:12         ` Yao Qi
2012-10-31 17:59         ` Pedro Alves
2012-10-31 19:20           ` Doug Evans
2012-11-01  0:34           ` Yao Qi
2012-11-02 15:46             ` Pedro Alves
2012-11-02 15:50               ` Pedro Alves
2012-10-18  1:16     ` Yao Qi
2012-10-18  1:28       ` Yao Qi
2012-10-30  7:07         ` [ping]: " Yao Qi
2012-10-30 17:22           ` Eli Zaretskii
2012-10-18  4:43       ` Eli Zaretskii
2012-10-18 19:54       ` Tom Tromey
2012-09-28 18:27   ` Tom Tromey
2012-09-28 18:29     ` Tom Tromey
2012-10-15 18:03   ` dje
2012-10-31 18:03     ` Pedro Alves
2012-10-31 19:10       ` Marc Khouzam
2012-11-01  0:22         ` Yao Qi
2012-11-22 18:33           ` Pedro Alves
2012-11-29 15:47             ` Yao Qi
2012-11-29 16:00               ` Pedro Alves
2012-11-29 19:34                 ` Marc Khouzam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5065E1E9.5040204@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox