From: Tom Tromey <tom@tromey.com>
To: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: Re: [PATCH v2 3/3] Make relocate_{path,gdb_directory} return std::string
Date: Wed, 11 Sep 2019 20:24:00 -0000 [thread overview]
Message-ID: <87y2yu37kt.fsf@tromey.com> (raw)
In-Reply-To: <20190910195816.199466-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Tue, 10 Sep 2019 14:58:16 -0500")
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
Christian> This simplifies memory management. I've also changed some global variables
Christian> to std::string accordingly (which store the result of these functions),
Christian> but not all because some are used with add_setshow_optional_filename_cmd
Christian> which requires a char*.
Christian> gdb/ChangeLog:
Christian> 2019-09-09 Christian Biesinger <cbiesinger@google.com>
Christian> * auto-load.c (auto_load_expand_dir_vars): Update.
Christian> * defs.h (gdb_datadir): Change to std::string.
Christian> (python_libdir): Likewise.
Christian> (relocate_gdb_directory): Change return type to std::string.
Christian> * guile/guile.c (gdbscm_data_directory): Update.
Christian> (initialize_scheme_side): Update.
Christian> * jit.c (jit_reader_dir): Change to std::string.
Christian> (jit_reader_load_command): Update.
Christian> * main.c (gdb_datadir): Change to std::string.
Christian> (python_libdir): Likewise.
Christian> (set_gdb_data_directory): Update.
Christian> (relocate_path): Change to return std::string.
Christian> (relocate_gdb_directory): Change to return std::string.
Christian> (relocate_gdbinit_path_maybe_in_datadir): Update.
Christian> (captured_main_1): Update.
Christian> * python/python.c (do_start_initialization): Update.
Christian> * top.c (show_gdb_datadir): Update.
Christian> * xml-syscall.c (xml_init_syscalls_info): Update.
Christian> (init_syscalls_info): Update.
Thanks, this is ok.
Tom
next prev parent reply other threads:[~2019-09-11 20:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 18:08 [PATCH 0/3] Refactor some path methods in main.c to use std::string Christian Biesinger via gdb-patches
2019-09-09 18:08 ` [PATCH 2/3] Factor out the code to do the datadir-relocation for gdbinit Christian Biesinger via gdb-patches
2019-09-10 15:15 ` Tom Tromey
2019-09-10 19:14 ` Christian Biesinger via gdb-patches
2019-09-10 19:14 ` [PATCH 2/3 v2] " Christian Biesinger via gdb-patches
2019-09-11 20:15 ` Tom Tromey
2019-09-09 18:08 ` [PATCH 1/3] Refactor get_init_files to use std::string Christian Biesinger via gdb-patches
2019-09-10 15:02 ` Tom Tromey
2019-09-10 19:23 ` [PATCH 1/3 v2] " Christian Biesinger via gdb-patches
2019-09-11 20:16 ` Tom Tromey
2019-09-09 18:08 ` [PATCH 3/3] Make relocate_{path,gdb_directory} return std::string Christian Biesinger via gdb-patches
2019-09-10 15:27 ` Tom Tromey
2019-09-10 19:56 ` Christian Biesinger via gdb-patches
2019-09-10 19:58 ` [PATCH v2 " Christian Biesinger via gdb-patches
2019-09-11 20:24 ` Tom Tromey [this message]
2019-09-11 20:22 ` [PATCH " Tom Tromey
2019-09-11 21:36 ` [PATCH 0/3] Refactor some path methods in main.c to use std::string Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2yu37kt.fsf@tromey.com \
--to=tom@tromey.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox