From: Tom Tromey <tom@tromey.com>
To: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>,
Christian Biesinger <cbiesinger@google.com>
Subject: Re: [PATCH 3/3] Make relocate_{path,gdb_directory} return std::string
Date: Wed, 11 Sep 2019 20:22:00 -0000 [thread overview]
Message-ID: <8736h24m77.fsf@tromey.com> (raw)
In-Reply-To: <CAPTJ0XH8dAKLtPZYKM3Sv83btP-AA3N3mYz-DYZEEoEDr9qg+A@mail.gmail.com> (Christian Biesinger via gdb-patches's message of "Tue, 10 Sep 2019 14:55:38 -0500")
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>> I wonder if using a unique_xmalloc_ptr would be better.
>> I suppose it doesn't matter hugely, but it would eliminate some of these
>> double allocations.
Christian> Do you mean for the return type of relocate_path and
Christian> relocate_gdb_directory? Hm.. I can change it if you want, but I'd
Christian> rather not -- not all codepaths go through an xmalloc (when
Christian> relocatable=false, or relocate_path returns null in
Christian> relocate_gdb_directory). So that would add some xstrdup calls that
Christian> would not otherwise be necessary.
Yeah. What you did sounds fine.
Tom
next prev parent reply other threads:[~2019-09-11 20:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 18:08 [PATCH 0/3] Refactor some path methods in main.c to use std::string Christian Biesinger via gdb-patches
2019-09-09 18:08 ` [PATCH 2/3] Factor out the code to do the datadir-relocation for gdbinit Christian Biesinger via gdb-patches
2019-09-10 15:15 ` Tom Tromey
2019-09-10 19:14 ` Christian Biesinger via gdb-patches
2019-09-10 19:14 ` [PATCH 2/3 v2] " Christian Biesinger via gdb-patches
2019-09-11 20:15 ` Tom Tromey
2019-09-09 18:08 ` [PATCH 1/3] Refactor get_init_files to use std::string Christian Biesinger via gdb-patches
2019-09-10 15:02 ` Tom Tromey
2019-09-10 19:23 ` [PATCH 1/3 v2] " Christian Biesinger via gdb-patches
2019-09-11 20:16 ` Tom Tromey
2019-09-09 18:08 ` [PATCH 3/3] Make relocate_{path,gdb_directory} return std::string Christian Biesinger via gdb-patches
2019-09-10 15:27 ` Tom Tromey
2019-09-10 19:56 ` Christian Biesinger via gdb-patches
2019-09-10 19:58 ` [PATCH v2 " Christian Biesinger via gdb-patches
2019-09-11 20:24 ` Tom Tromey
2019-09-11 20:22 ` Tom Tromey [this message]
2019-09-11 21:36 ` [PATCH 0/3] Refactor some path methods in main.c to use std::string Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736h24m77.fsf@tromey.com \
--to=tom@tromey.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox