From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105597 invoked by alias); 11 Sep 2019 20:22:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105588 invoked by uid 89); 11 Sep 2019 20:22:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Sep 2019 20:22:55 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway22.websitewelcome.com (Postfix) with ESMTP id CBC746EC89 for ; Wed, 11 Sep 2019 15:22:53 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 898fiR1R5dnCe898fim1KG; Wed, 11 Sep 2019 15:22:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WixkraDSSz9FU1oBIkrnLAiYWH26YQPZ59+NfGiWUUQ=; b=Vg+Vzm5rbhaQ9iyZWOLHT3bZit np0/bg+geMSGR/cRfZ9cpuDX8/DRZWjoh+0GJacZn3ir/Q/3Bbeu5TJRUT3dFR9QnR4IXgo/jD1xU 40Sn94ykqEy42/VIJCVIz6hY9; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:43716 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i898f-003XPh-IP; Wed, 11 Sep 2019 15:22:53 -0500 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Tom Tromey , Christian Biesinger Subject: Re: [PATCH 3/3] Make relocate_{path,gdb_directory} return std::string References: <20190909180830.215313-1-cbiesinger@google.com> <20190909180830.215313-4-cbiesinger@google.com> <87ftl46uke.fsf@tromey.com> Date: Wed, 11 Sep 2019 20:22:00 -0000 In-Reply-To: (Christian Biesinger via gdb-patches's message of "Tue, 10 Sep 2019 14:55:38 -0500") Message-ID: <8736h24m77.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00209.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: >> I wonder if using a unique_xmalloc_ptr would be better. >> I suppose it doesn't matter hugely, but it would eliminate some of these >> double allocations. Christian> Do you mean for the return type of relocate_path and Christian> relocate_gdb_directory? Hm.. I can change it if you want, but I'd Christian> rather not -- not all codepaths go through an xmalloc (when Christian> relocatable=false, or relocate_path returns null in Christian> relocate_gdb_directory). So that would add some xstrdup calls that Christian> would not otherwise be necessary. Yeah. What you did sounds fine. Tom