From: Tom Tromey <tom@tromey.com>
To: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: Re: [PATCH 1/3] Refactor get_init_files to use std::string
Date: Tue, 10 Sep 2019 15:02:00 -0000 [thread overview]
Message-ID: <87o8zs6vpe.fsf@tromey.com> (raw)
In-Reply-To: <20190909180830.215313-2-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Mon, 9 Sep 2019 13:08:28 -0500")
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
Christian> To avoid manual memory management.
Christian> Tested on buildbot.
Thank you for the patch.
Christian> + relocated_sysgdbinit = std::string (gdb_datadir) + SLASH_STRING +
Christian> + &SYSTEM_GDBINIT[start];
This needs parens around the RHS so that the indentation is correct
according to GNU standards.
Christian> + if (!relocated_sysgdbinit.empty () &&
&& on the start of a line, not the end.
This is ok with those nits fixed.
Tom
next prev parent reply other threads:[~2019-09-10 15:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 18:08 [PATCH 0/3] Refactor some path methods in main.c " Christian Biesinger via gdb-patches
2019-09-09 18:08 ` [PATCH 2/3] Factor out the code to do the datadir-relocation for gdbinit Christian Biesinger via gdb-patches
2019-09-10 15:15 ` Tom Tromey
2019-09-10 19:14 ` Christian Biesinger via gdb-patches
2019-09-10 19:14 ` [PATCH 2/3 v2] " Christian Biesinger via gdb-patches
2019-09-11 20:15 ` Tom Tromey
2019-09-09 18:08 ` [PATCH 1/3] Refactor get_init_files to use std::string Christian Biesinger via gdb-patches
2019-09-10 15:02 ` Tom Tromey [this message]
2019-09-10 19:23 ` [PATCH 1/3 v2] " Christian Biesinger via gdb-patches
2019-09-11 20:16 ` Tom Tromey
2019-09-09 18:08 ` [PATCH 3/3] Make relocate_{path,gdb_directory} return std::string Christian Biesinger via gdb-patches
2019-09-10 15:27 ` Tom Tromey
2019-09-10 19:56 ` Christian Biesinger via gdb-patches
2019-09-10 19:58 ` [PATCH v2 " Christian Biesinger via gdb-patches
2019-09-11 20:24 ` Tom Tromey
2019-09-11 20:22 ` [PATCH " Tom Tromey
2019-09-11 21:36 ` [PATCH 0/3] Refactor some path methods in main.c to use std::string Christian Biesinger via gdb-patches
-- strict thread matches above, loose matches on Subject: below --
2019-08-20 22:17 [PATCH 0/3] [RFC] Load gdbinit files from a directory Christian Biesinger via gdb-patches
2019-08-20 22:18 ` [PATCH 1/3] Refactor get_init_files to use std::string Christian Biesinger via gdb-patches
2019-08-21 17:13 ` Sergio Durigan Junior
2019-08-21 17:29 ` Christian Biesinger via gdb-patches
2019-08-21 17:34 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8zs6vpe.fsf@tromey.com \
--to=tom@tromey.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox