From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51579 invoked by alias); 10 Sep 2019 15:02:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51371 invoked by uid 89); 10 Sep 2019 15:02:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:605, management X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.46.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Sep 2019 15:02:26 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway21.websitewelcome.com (Postfix) with ESMTP id DB984400C9F58 for ; Tue, 10 Sep 2019 10:02:22 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 7hewik5QX2qH77hewieIxd; Tue, 10 Sep 2019 10:02:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=K3OAsZK5F1NiwH0v0EB56a7bUkWWi4pwzXYVEcaTwXo=; b=AMhgGgyoKLddBwYQ5VKKYEAzej CV3M23ZUvolUMFc3W1OCeMKwj9NAZr1Fpl/byNaVVdRlGiKaPZ0aZZ5o/zMrZcNiMfCB/XoSiY+n/ YXBV9gnEFQlCIUVyunAPtxccD; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:57170 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i7hew-003NrW-Gx; Tue, 10 Sep 2019 10:02:22 -0500 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Christian Biesinger Subject: Re: [PATCH 1/3] Refactor get_init_files to use std::string References: <20190909180830.215313-1-cbiesinger@google.com> <20190909180830.215313-2-cbiesinger@google.com> Date: Tue, 10 Sep 2019 15:02:00 -0000 In-Reply-To: <20190909180830.215313-2-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Mon, 9 Sep 2019 13:08:28 -0500") Message-ID: <87o8zs6vpe.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00158.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> To avoid manual memory management. Christian> Tested on buildbot. Thank you for the patch. Christian> + relocated_sysgdbinit = std::string (gdb_datadir) + SLASH_STRING + Christian> + &SYSTEM_GDBINIT[start]; This needs parens around the RHS so that the indentation is correct according to GNU standards. Christian> + if (!relocated_sysgdbinit.empty () && && on the start of a line, not the end. This is ok with those nits fixed. Tom