From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107323 invoked by alias); 11 Sep 2019 20:24:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107169 invoked by uid 89); 11 Sep 2019 20:24:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=management X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.168.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Sep 2019 20:24:16 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 472B7C33C for ; Wed, 11 Sep 2019 15:24:04 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 899oiuqRB2PzO899oiogFv; Wed, 11 Sep 2019 15:24:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=esqY1QiuNSyefBnsF2SFQ9jDG/xNtfBKmTovnZfqTi0=; b=U146h8g3jHquwvLXw8u+436Fcf o1+pJsU9rad3S0FIXRvnlftZYUijxXMEbfpduZoZkounKWoUV1aGK9gcWqtQE/4ULCVClS3a6awgE LTM0h2IrSPEORrGnNOXQpJELZ; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:43732 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i899o-003Xhj-0a; Wed, 11 Sep 2019 15:24:04 -0500 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Christian Biesinger Subject: Re: [PATCH v2 3/3] Make relocate_{path,gdb_directory} return std::string References: <20190910195816.199466-1-cbiesinger@google.com> Date: Wed, 11 Sep 2019 20:24:00 -0000 In-Reply-To: <20190910195816.199466-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Tue, 10 Sep 2019 14:58:16 -0500") Message-ID: <87y2yu37kt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00210.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> This simplifies memory management. I've also changed some global variables Christian> to std::string accordingly (which store the result of these functions), Christian> but not all because some are used with add_setshow_optional_filename_cmd Christian> which requires a char*. Christian> gdb/ChangeLog: Christian> 2019-09-09 Christian Biesinger Christian> * auto-load.c (auto_load_expand_dir_vars): Update. Christian> * defs.h (gdb_datadir): Change to std::string. Christian> (python_libdir): Likewise. Christian> (relocate_gdb_directory): Change return type to std::string. Christian> * guile/guile.c (gdbscm_data_directory): Update. Christian> (initialize_scheme_side): Update. Christian> * jit.c (jit_reader_dir): Change to std::string. Christian> (jit_reader_load_command): Update. Christian> * main.c (gdb_datadir): Change to std::string. Christian> (python_libdir): Likewise. Christian> (set_gdb_data_directory): Update. Christian> (relocate_path): Change to return std::string. Christian> (relocate_gdb_directory): Change to return std::string. Christian> (relocate_gdbinit_path_maybe_in_datadir): Update. Christian> (captured_main_1): Update. Christian> * python/python.c (do_start_initialization): Update. Christian> * top.c (show_gdb_datadir): Update. Christian> * xml-syscall.c (xml_init_syscalls_info): Update. Christian> (init_syscalls_info): Update. Thanks, this is ok. Tom